Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

nturgut
Copy link
Contributor

@nturgut nturgut commented Jan 15, 2020

Implementing Clipboard.setData system channel message for browsers who does not support ClipboardAPI.

html.document.execCommand('copy') is used.

Fixes: flutter/flutter#48578

@nturgut nturgut added the platform-web Code specifically for the web engine label Jan 15, 2020
@nturgut nturgut requested a review from mdebbar January 15, 2020 17:21
@auto-assign auto-assign bot requested a review from jason-simmons January 15, 2020 17:21
@nturgut nturgut removed the request for review from jason-simmons January 15, 2020 17:21
@nturgut nturgut requested a review from mdebbar January 15, 2020 18:25
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nturgut
Copy link
Contributor Author

nturgut commented Jan 15, 2020

Thanks again for the review!

@nturgut nturgut merged commit be20fb6 into flutter:master Jan 15, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 16, 2020
flutter/engine@3488051...be20fb6

git log 3488051..be20fb6 --first-parent --oneline
2020-01-15 [email protected] [web] Exec command copy (flutter/engine#15675)
2020-01-15 [email protected] Disable fml_unittests till flakes are addressed. (flutter/engine#15676)
2020-01-15 [email protected] Roll src/third_party/dart fe666ce592cb..862d5012ae9c (48 commits) (flutter/engine#15672)
2020-01-15 [email protected] Fix hardware keyboard enter so it triggers an action. (flutter/engine#15568)
2020-01-15 [email protected] Use iOS 13 dark content status bar style (flutter/engine#13119)
2020-01-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from oxHfW... to UlOSN... (flutter/engine#15670)
2020-01-15 [email protected] Roll src/third_party/skia e45c5cd03eeb..7655168e6865 (29 commits) (flutter/engine#15671)
2020-01-15 [email protected] Fix embedder mutation order (flutter/engine#15566)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@nturgut nturgut mentioned this pull request Jan 23, 2020
11 tasks
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
* clipboard support with range

* changing the implementation to work on Safari

* addressing PR comments

* changing value back to text

* when textarea.value is used select was also working
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
* clipboard support with range

* changing the implementation to work on Safari

* addressing PR comments

* changing value back to text

* when textarea.value is used select was also working
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] support Clipboard.setData platform messages for browser doesn't have Clipboard API
3 participants