This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use ELF for Dart AOT snapshots on Fuchsia. #13896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Nov 18, 2019
sjindel-google
commented
Nov 19, 2019
|
@sjindel-google ping just so this doesn't get forgotten :) |
|
@cbracken I'm (still) trying to test this on Fuchsia :) |
|
After discussion with Kaushik, it will be easier to test if I make the same change to the Flutter runner as well. |
|
Update: Fuchsia's |
sjindel-google
force-pushed
the
sjindel.fuch
branch
from
33ecc9b to
c876053
Compare
|
Once https://dart-review.googlesource.com/c/sdk/+/127641 rolls into Flutter, this should be good to go. I've tested this with the spinning-cube example in the Fuchsia tree. |
sjindel-google
changed the title
sjindel-google
force-pushed
the
sjindel.fuch
branch
from
c876053 to
dc8431e
Compare
|
The dependent change has rolled into Flutter, so this should be ready to go. |
|
I can't explain the presubmit error. It is trying to check a file that has moved. @iskakaushik Do you have any ideas? |
|
The presubmit script is flagging the formatting of Delete the space before the comma on the lines that were added to that file. Or try running the |
sjindel-google
force-pushed
the
sjindel.fuch
branch
from
dc8431e to
a41aa37
Compare
|
I have tested this locally, with and without ELF available. I'm just waiting for the engine build to turn green again to land. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2019
flar
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 20, 2019
* bb118c6 Roll src/third_party/dart 8d11c1dce64a..642f8d052fd7 (1 commits) (flutter/engine#14574) * 09c434d Use ELF for Dart AOT snapshots on Fuchsia. (flutter/engine#13896) * e1e7851 Roll fuchsia/sdk/core/linux-amd64 from VdBKA... to uFFWW... (flutter/engine#14575) * f317f8f Roll src/third_party/skia c76ac8e325c7..77742c350371 (1 commits) (flutter/engine#14576) * 2ba5633 instructions for running firefox/safari tests (flutter/engine#14562) * 9cf1e46 Roll src/third_party/dart 642f8d052fd7..7113fc79a83c (3 commits) (flutter/engine#14578) * f5b877a [web] Run engine tests on Safari locally by launching safari installed on MacOS (flutter/engine#14555) * 68d9196 Fix DOM-based ParagraphRuler.hitTest() (flutter/engine#14504) * bb65df8 Roll src/third_party/skia 77742c350371..a8352ccaae37 (8 commits) (flutter/engine#14579) * ad1ab56 Roll src/third_party/dart 7113fc79a83c..e50d98cd5651 (8 commits) (flutter/engine#14580) * 22413ef Update formatting in web_ui scene bulder to match flutter style and dartfmt. (flutter/engine#14539) * 6e825e7 Roll fuchsia/sdk/core/mac-amd64 from Ykb4b... to f51Q_... (flutter/engine#14584) * 1d3bb8c Fix message_loop_fuchsia and thus enable fml_tests and flow_tests for Fuchsia (flutter/engine#14583) * 1f7bb9d Wire up OpacityLayer to Scenic (flutter/engine#14577) * 11db035 Roll src/third_party/skia a8352ccaae37..87e9ddb675b6 (11 commits) (flutter/engine#14585) * bd58af7 Roll src/third_party/dart e50d98cd5651..141fcfa61092 (3 commits) (flutter/engine#14586) * 929b1ed Engine support for ImageFiltered widget (flutter/engine#14491) * 40b84fc Fix lint warnings across web_ui, add missing browserEngine case in text field. (flutter/engine#14535) * ea1d330 Roll fuchsia/sdk/core/linux-amd64 from uFFWW... to 25LzW... (flutter/engine#14587) * 854d5f8 Roll src/third_party/skia 87e9ddb675b6..7e2dea568299 (1 commits) (flutter/engine#14589)
franciscojma86
added a commit
to franciscojma86/engine
that referenced
this pull request
Dec 27, 2019
This reverts commit 09c434d.
franciscojma86
added a commit
that referenced
this pull request
Dec 28, 2019
sjindel-google
added a commit
that referenced
this pull request
Jan 10, 2020
The bug in the original CL was that we were not running replace_as_executable in OpenVmo if the namespace was not provided. This was a divergence in behavior for MappedResource::LoadFromNamespace compared to the current implementation.
|
The flutter tool should also be updated: |
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…lutter#15360) The bug in the original CL was that we were not running replace_as_executable in OpenVmo if the namespace was not provided. This was a divergence in behavior for MappedResource::LoadFromNamespace compared to the current implementation.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…3896" (flutter#15360)" This reverts commit 949be9d.
creatint
pushed a commit
to creatint/topaz
that referenced
this pull request
Mar 3, 2020
Depends on flutter/engine#13896. Change-Id: Ib74264e1e5bf6cabb72dd080190b272209f517a9
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
We will still support loading blobs until build rules in Fuchsia are updated.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…lutter#14823) This reverts commit 09c434d.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…lutter#15360) The bug in the original CL was that we were not running replace_as_executable in OpenVmo if the namespace was not provided. This was a divergence in behavior for MappedResource::LoadFromNamespace compared to the current implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the last uses of AOT blob snapshots from Flutter.