Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

nturgut
Copy link
Contributor

@nturgut nturgut commented Dec 19, 2019

Adding instructions to felt documentation for running Flutter Web engine tests on firefox and safari.

@nturgut nturgut requested review from yjbanov and ferhatb December 19, 2019 01:05
@auto-assign auto-assign bot requested a review from franciscojma86 December 19, 2019 01:05
@nturgut nturgut removed the request for review from franciscojma86 December 19, 2019 01:05
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's happening!!!

LGTM

@nturgut
Copy link
Contributor Author

nturgut commented Dec 19, 2019

Thanks! I'll wait until #14555 is in.

@nturgut nturgut merged commit 2ba5633 into master Dec 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
flar pushed a commit to flutter/flutter that referenced this pull request Dec 20, 2019
* bb118c6 Roll src/third_party/dart 8d11c1dce64a..642f8d052fd7 (1 commits) (flutter/engine#14574)

* 09c434d Use ELF for Dart AOT snapshots on Fuchsia. (flutter/engine#13896)

* e1e7851 Roll fuchsia/sdk/core/linux-amd64 from VdBKA... to uFFWW... (flutter/engine#14575)

* f317f8f Roll src/third_party/skia c76ac8e325c7..77742c350371 (1 commits) (flutter/engine#14576)

* 2ba5633 instructions for running firefox/safari tests (flutter/engine#14562)

* 9cf1e46 Roll src/third_party/dart 642f8d052fd7..7113fc79a83c (3 commits) (flutter/engine#14578)

* f5b877a [web] Run engine tests on Safari locally by launching safari installed on MacOS (flutter/engine#14555)

* 68d9196 Fix DOM-based ParagraphRuler.hitTest() (flutter/engine#14504)

* bb65df8 Roll src/third_party/skia 77742c350371..a8352ccaae37 (8 commits) (flutter/engine#14579)

* ad1ab56 Roll src/third_party/dart 7113fc79a83c..e50d98cd5651 (8 commits) (flutter/engine#14580)

* 22413ef Update formatting in web_ui scene bulder to match flutter style and dartfmt. (flutter/engine#14539)

* 6e825e7 Roll fuchsia/sdk/core/mac-amd64 from Ykb4b... to f51Q_... (flutter/engine#14584)

* 1d3bb8c Fix message_loop_fuchsia and thus enable fml_tests and flow_tests for Fuchsia (flutter/engine#14583)

* 1f7bb9d Wire up OpacityLayer to Scenic (flutter/engine#14577)

* 11db035 Roll src/third_party/skia a8352ccaae37..87e9ddb675b6 (11 commits) (flutter/engine#14585)

* bd58af7 Roll src/third_party/dart e50d98cd5651..141fcfa61092 (3 commits) (flutter/engine#14586)

* 929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)

* 40b84fc Fix lint warnings across web_ui, add missing browserEngine case in text field. (flutter/engine#14535)

* ea1d330 Roll fuchsia/sdk/core/linux-amd64 from uFFWW... to 25LzW... (flutter/engine#14587)

* 854d5f8 Roll src/third_party/skia 87e9ddb675b6..7e2dea568299 (1 commits) (flutter/engine#14589)
@chinmaygarde chinmaygarde deleted the nturgut-doc-felt branch January 17, 2020 01:35
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
* instructions for running firefox/safari tests

* addressing reviewer comments.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants