Use a version wildcard for MEL dependency #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.4.0 Release
2.0.0 Release
2.0.1 Release
2.0.2 Release
|
Thanks! Let's give this a try 👍 I've re-targeted it to |
Merged
SimonCropp
reviewed
Apr 23, 2019
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net461' or '$(TargetFramework)' == 'netstandard2.0' "> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="2.*" /> |
There was a problem hiding this comment.
note that this wont effect the resulting package. on each build the resultant nuget will have the current release version of Microsoft.Extensions.Logging hard coded as a package dependency
There was a problem hiding this comment.
Argh, thanks Simon - lost track of this particular footgun :-)
There was a problem hiding this comment.
I only remember due to my missing foot
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added floating version for PackageReference Microsoft.Extensions.Logging to 2.*