Skip to content

Use a version wildcard for MEL dependency #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2019
Merged

Use a version wildcard for MEL dependency #133

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9e9994
Merge pull request #68 from serilog/dev
nblumhardt Feb 14, 2017
8ed7d97
Merge pull request #91 from serilog/dev
nblumhardt Aug 18, 2017
3f639e3
Merge pull request #105 from serilog/dev
merbla Aug 28, 2017
8cf5db7
Merge pull request #107 from serilog/dev
nblumhardt Aug 28, 2017
e766195
Changed version on Microsoft.Extensions.Logging to 2.2.*
simenhagelid Mar 13, 2019
0ad9a62
Added floating version for Microsoft.Extensions.Logging reference
simenhagelid Mar 13, 2019
bbd54ce
Bump version to 2.0.3
simenhagelid Mar 13, 2019
6116e46
Merge branch 'dev' into master
nblumhardt Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Serilog.Extensions.Logging/Serilog.Extensions.Logging.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<Description>Low-level Serilog provider for Microsoft.Extensions.Logging</Description>
<VersionPrefix>2.0.1</VersionPrefix>
<VersionPrefix>2.0.3</VersionPrefix>
<Authors>Microsoft;Serilog Contributors</Authors>
<TargetFrameworks>net45;net46;net461;netstandard1.3;netstandard2.0</TargetFrameworks>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
Expand Down Expand Up @@ -31,7 +31,7 @@
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net461' or '$(TargetFramework)' == 'netstandard2.0' ">
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.*" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this wont effect the resulting package. on each build the resultant nuget will have the current release version of Microsoft.Extensions.Logging hard coded as a package dependency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, thanks Simon - lost track of this particular footgun :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only remember due to my missing foot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net46' ">
Expand Down