Skip to content

Conversation

nblumhardt
Copy link
Member

merbla and others added 6 commits November 17, 2016 09:26
* Serilog -> 2.3.0
* Microsoft.Extensions.Logging.Abstractions -> 1.1.0
# Conflicts:
#	src/Serilog.Extensions.Logging/project.json
Fix issue 928 (Missed EF events)
@nblumhardt
Copy link
Member Author

@merbla the update to MEL 1.1 could edge out some users still on 1.0, since upgrading drags forwards a whole bunch of other framework libraries. I'm still okay with this (we're not withdrawing the support already out there in 1.3.x of this lib) but now that we have bug fixes in this release I wonder whether going back to 1.0 (while keeping the updated Serilog dependency) might be a bit more accommodating. Thoughts?

@nblumhardt
Copy link
Member Author

Attempting to back out the MEL dependency version bump isn't going so well - #69 - but I'd still rather support 1.0.0 if we can. Any ideas why that PR doesn't build?

@skomis-mm
Copy link

skomis-mm commented Feb 14, 2017

@nblumhardt , I think the problem is with these lines for net45(6). Contract reference to System.Runtime was unneeded for 1.1 since it was already referenced there so I removed them in that PR.
So for backing up we need return these references or better put them in frameworkAssemblies section so they won't appear in .nuspec:

"frameworkAssemblies": { "System.Runtime": { "type": "build" } }

@nblumhardt
Copy link
Member Author

Thanks @skomis-mm 👍

@nblumhardt nblumhardt merged commit d9e9994 into master Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants