Rollup of 20 pull requests #22439
Closed
Rollup of 20 pull requests #22439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without such a clarification, people who know and love closures (for instance programmers with a Haskell background) might fear that types would have to be declared in closures and that therefore using closures would be much more unwieldy.
The `Arguments::new_v1_formatted` function was accidentally left out when this module was stabilized.
This brings it in line with its namesake in `std::io`. [breaking-change]
Some newcomers might look for a "flatMap" method on Option. Include the reference so that searching the page would find "and_then".
When matching against strings/slices, we call the comparison function for strings, which takes two string slices by value. The slices are passed in memory, and currently we just pass in a pointer to the original slice. That can cause misoptimizations because we emit a call to llvm.lifetime.end for all by-value arguments at the end of a function, which in this case marks the original slice as dead. So we need to properly create copies of the slices to pass them to the comparison function. Fixes rust-lang#22008
The other cases: `concat_idents!`, `log_syntax!`, and `trace_macros!`, (these macros, with `asm!`, are handled (eagerly) in feature_gate.rs).
Requested by Niko in rust-lang#22200 (and is good to have anyway)
- We shouldn't be using `check_name` here at all - `contains_name(ref_slice(foo), bar)` is redundant, `contains_name` just iterates over its first arg and calls `check_name` - match would be better than a bunch of ifs
This redux of CONTRIBUTING.md adds in more information, including subsuming both compliment-bugreport.md and Note-development-policy in the wiki. I only glanced at the broad TOC of Note-development-policy, and did not use the text as the basis for the re-write. This will then address the last outstanding part of rust-lang#5831.
The test "signal_reported_right" send a signal `1` to `/bin/sh`, and check the status code to check if the signal is reported right. Under OpenBSD, the signal `1` (`SIGHUP`) is catched by `/bin/sh`, resulting the test failed. Use the uncatchable signal `9` (`SIGKILL`) for test.
This commit mostly replaces some of the uses of os::args with env::args.
Fixes rust-lang#19321
…eklabnik This is a more introductory document, suitable for Part II. The arcane details move to an "Advanced macros" chapter in Part III. Conflicts: src/doc/trpl/macros.md
|
⌛ Testing commit a672498 with merge 5e92d33... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@Manishearth this patch should fix the other windows failure: From b1f8e58045ec798abcd0d36d93d59f60b0595e52 Mon Sep 17 00:00:00 2001
From: Simonas Kazlauskas <[email protected]>
Date: Tue, 17 Feb 2015 15:50:18 +0200
Subject: [PATCH] use ops::Range instead of iter::Range
---
src/libstd/sys/windows/os.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libstd/sys/windows/os.rs b/src/libstd/sys/windows/os.rs
index 6aa1ac0..502d70d 100644
--- a/src/libstd/sys/windows/os.rs
+++ b/src/libstd/sys/windows/os.rs
@@ -18,7 +18,7 @@ use os::windows::*;
use error::Error as StdError;
use ffi::{OsString, OsStr, AsOsStr};
use fmt;
-use iter::Range;
+use ops::Range;
use libc::types::os::arch::extra::LPWCH;
use libc::{self, c_int, c_void};
use mem;
@@ -319,7 +319,7 @@ pub fn args() -> Args {
let lpCmdLine = c::GetCommandLineW();
let szArgList = c::CommandLineToArgvW(lpCmdLine, &mut nArgs);
- Args { cur: szArgList, range: range(0, nArgs as isize) }
+ Args { cur: szArgList, range: 0..(nArgs as isize) }
}
}
--
2.3.0You can also merge it from the PR if you want, but you should keep in mind I didn’t test it on windows either. |
|
(i am looking into whether I can recover a useful rollup PR from this work without too much effort) |
|
@bors r=10f51fc |
|
🙀 You have the wrong number! Please try again with |
|
⌛ Testing commit 10f51fc with merge 076a920... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
⌛ Testing commit 096b105 with merge b2c68cd... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
I'll take this over, starting anew with lots more PRs as well. |
|
see #22475 (which seems to have ended with a manual merge, what a saga! |
|
Yeah, I've been watching that one, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem,nonzero, andcellmodules for proper integer usage #22401, Replace some uses of deprecated os (mostly os::args) functions #22402, Remove hax #22408, Fixed typo and removed unfitting 'can' #22410, Make io::Seek docs less prescriptive #22433fmt::Writertofmt::Write#22311 Give float some examples #22030 Pass features along during expansion #22383 (Implement ExactSizeIterator for Args and ArgsOs #22400 contained in this as well)