Remove hax #22408
Merged
Remove hax #22408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#19321
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I know nothing of this hack. @alexcrichton do you? I'm inclined to just r+ and see what happens, I guess. |
|
Hm yes I do think we take care of this use case now. At least if it doesn't bounce on the bots it works for me! |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 17, 2015
Fixes rust-lang#19321 ... I think? `make check` passes, but I'm not 100% sure that there's a test for that behavior. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19321
... I think?
make checkpasses, but I'm not 100% sure that there's a test for that behavior. Thoughts?