Remove use of range() in iterator docs. #22296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
||
| ```{rust} | ||
| ```rust | ||
| let nums = vec![1, 2, 3]; | ||
|
|
||
| for i in range(0, nums.len()) { |
There was a problem hiding this comment.
lol and others, fixed them too
steveklabnik
force-pushed
the
gh21577
branch
from
a1a36ab to
bc7c907
Compare
| @@ -4,20 +4,20 @@ Let's talk about loops. | |||
|
|
|||
| Remember Rust's `for` loop? Here's an example: | |||
|
|
|||
| ```{rust} | |||
| for x in range(0, 10) { | |||
| ``` | |||
steveklabnik
force-pushed
the
gh21577
branch
from
bc7c907 to
debecf4
Compare
| ```{rust} | ||
| let sum = range(1, 4) | ||
| ```rust | ||
| let sum = 1..4 | ||
| .fold(0, |sum, x| sum + x); |
There was a problem hiding this comment.
Parentheses needed around (1..4) here, else it is 1..(4.fold(---))
steveklabnik
force-pushed
the
gh21577
branch
from
debecf4 to
817f3a4
Compare
|
Feedback addressed. @gankro r? |
|
@bors r+ 817f3 rollup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21577.