Introduce rustfmt
#499
Merged
Introduce rustfmt
#499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
11-02-rustfmt
branch
from
b28092b to
135a304
Compare
Member
Author
|
WTF, the format change fail in CI is to a line that I cannot find in locally. |
Contributor
|
(A bit off-topic) @tcharding What do you think about: rust-lang/rustfmt#5584 ? |
Member
Author
I like the idea, not sure why the lad is so unequivocally against it. I don't think it helps us though since "existing" is unformatted the "desired" would never be triggered. |
Contributor
That's a good point. It only helps projects that are already formatted. |
tcharding
force-pushed
the
11-02-rustfmt
branch
from
135a304 to
5986121
Compare
As we did in `rust-bitcoin` introduced a `rustfmt` configuration file that is palatable to devs. Do not run formatter, that is done as a separate patch to assist review.
In preparation for running the formatter do minor refactorings and add a bunch of `rustfmt::skip` directives.
Run the command `cargo +nightly fmt` to fix formatting issues. The formatter got confused in one place, adding an incorrect indentation, this was manually fixed.
tcharding
force-pushed
the
11-02-rustfmt
branch
from
5986121 to
e0e575d
Compare
Member
Author
|
Please note the recently added deprecated "since" strings are so long that they now go over multiple lines, its ugly but I figured since we remove them in a release anyway I'd leave them as is. Can change if required. |
apoelstra
approved these changes
Nov 17, 2022
Member
|
Will hold off on merging this for a bit since there are other PRs in flight and I think this'll conflict with everything. |
Member
Author
|
For me its better to just merge this one first please, I find these rustfmt PRs super boring to do where as I'm ok to rebase the others because they are much more interesting work. The only active PRs are my two I think. |
Member
|
Hah, fair enough. Merging now. |
Merged
Merged
apoelstra
added a commit
that referenced
this pull request
Nov 22, 2022
75f3886 Add cargo fmt to pre-commit githook (Tobin C. Harding) 0516dde Add formatting check to CI (Tobin C. Harding) c7807df Run the formatter (Tobin C. Harding) Pull request description: We recently introduced `rustfmt` to the codebase but I forgot to turn it on in CI. - Patch 1: Preparatory formatting fixes, introduced since we merged the [formatting PR](#499) - Patch 2: Enable formatting in CI - Patch 3: Add formatting to the pre-commit hook ACKs for top commit: apoelstra: ACK 75f3886 Tree-SHA512: 5ac4ab4015a9728ef890e0c4fe90afcb5e45ab7665da5a8ee289dc877c1ea5c6236e54b68b7122841597864b04606c8bfae7dec86c4b6be74d32437299057b5f
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
e0e575dde71a39de815bc6268e2d9f3c671366cc Run cargo fmt (Tobin C. Harding)
41449e455dfb14d11e9cccf0d13db08c2d008cfe Prepare codebase for formatting (Tobin C. Harding)
7e3c8935b621f3e76bd0e6e5f072258f5f64dffd Introduce rustfmt config file (Tobin C. Harding)
Pull request description:
(Includes the patch from #504, I pulled it out of this to merge faster)
Introduce `rustfmt` by doing:
- Copy the `rustfmt` config file from `rust-bitcoin`
- Prepare the codebase by adding `#[rustfmt::skip]` as needed and doing some manual format improvements.
- Run the formatter: `cargo +nightly fmt`
- Add formatting checks to CI and the pre-commit hook
Thanks in advance for doing the painful review on patch 3.
ACKs for top commit:
apoelstra:
ACK e0e575dde71a39de815bc6268e2d9f3c671366cc
Tree-SHA512: 1b6fdbaf81480c0446e660cc3f6ab7ac0697f272187f6fdfd6b95d894a418cde8cf1c423f1d18ebbe03ac5c43489630a35ad07912afaeb6107cfbe7338a9bed7
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
75f3886812a70aa7821d3de38bf2e8c94cfd9ef4 Add cargo fmt to pre-commit githook (Tobin C. Harding) 0516ddeb8d62e88b3943406969a7665a5f123999 Add formatting check to CI (Tobin C. Harding) c7807dff9c2e772179c97f396be60ef37b2d7ba2 Run the formatter (Tobin C. Harding) Pull request description: We recently introduced `rustfmt` to the codebase but I forgot to turn it on in CI. - Patch 1: Preparatory formatting fixes, introduced since we merged the [formatting PR](rust-bitcoin/rust-secp256k1#499) - Patch 2: Enable formatting in CI - Patch 3: Add formatting to the pre-commit hook ACKs for top commit: apoelstra: ACK 75f3886812a70aa7821d3de38bf2e8c94cfd9ef4 Tree-SHA512: 5ac4ab4015a9728ef890e0c4fe90afcb5e45ab7665da5a8ee289dc877c1ea5c6236e54b68b7122841597864b04606c8bfae7dec86c4b6be74d32437299057b5f
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
e0e575dde71a39de815bc6268e2d9f3c671366cc Run cargo fmt (Tobin C. Harding)
41449e455dfb14d11e9cccf0d13db08c2d008cfe Prepare codebase for formatting (Tobin C. Harding)
7e3c8935b621f3e76bd0e6e5f072258f5f64dffd Introduce rustfmt config file (Tobin C. Harding)
Pull request description:
(Includes the patch from #504, I pulled it out of this to merge faster)
Introduce `rustfmt` by doing:
- Copy the `rustfmt` config file from `rust-bitcoin`
- Prepare the codebase by adding `#[rustfmt::skip]` as needed and doing some manual format improvements.
- Run the formatter: `cargo +nightly fmt`
- Add formatting checks to CI and the pre-commit hook
Thanks in advance for doing the painful review on patch 3.
ACKs for top commit:
apoelstra:
ACK e0e575dde71a39de815bc6268e2d9f3c671366cc
Tree-SHA512: 1b6fdbaf81480c0446e660cc3f6ab7ac0697f272187f6fdfd6b95d894a418cde8cf1c423f1d18ebbe03ac5c43489630a35ad07912afaeb6107cfbe7338a9bed7
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
75f3886812a70aa7821d3de38bf2e8c94cfd9ef4 Add cargo fmt to pre-commit githook (Tobin C. Harding) 0516ddeb8d62e88b3943406969a7665a5f123999 Add formatting check to CI (Tobin C. Harding) c7807dff9c2e772179c97f396be60ef37b2d7ba2 Run the formatter (Tobin C. Harding) Pull request description: We recently introduced `rustfmt` to the codebase but I forgot to turn it on in CI. - Patch 1: Preparatory formatting fixes, introduced since we merged the [formatting PR](rust-bitcoin/rust-secp256k1#499) - Patch 2: Enable formatting in CI - Patch 3: Add formatting to the pre-commit hook ACKs for top commit: apoelstra: ACK 75f3886812a70aa7821d3de38bf2e8c94cfd9ef4 Tree-SHA512: 5ac4ab4015a9728ef890e0c4fe90afcb5e45ab7665da5a8ee289dc877c1ea5c6236e54b68b7122841597864b04606c8bfae7dec86c4b6be74d32437299057b5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Includes the patch from #504, I pulled it out of this to merge faster)
Introduce
rustfmtby doing:rustfmtconfig file fromrust-bitcoin#[rustfmt::skip]as needed and doing some manual format improvements.cargo +nightly fmtThanks in advance for doing the painful review on patch 3.