Run the formatter in CI #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are not running the formatter in CI, in preparation for doing so run `cargo +nightly fmt` to clear all current formatting issues. No manual changes.
Add code to the CI script, guarded on env var `DO_FMT` to run the formatter. Add a formatting job to the nightly CI job as a separate step, in a similar fashion to how the other nightly steps are done.
To save devs getting frustrated by CI; add a call to `cargo +nightly fmt` to our git pre-commit hook.
apoelstra
approved these changes
Nov 22, 2022
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
75f3886812a70aa7821d3de38bf2e8c94cfd9ef4 Add cargo fmt to pre-commit githook (Tobin C. Harding) 0516ddeb8d62e88b3943406969a7665a5f123999 Add formatting check to CI (Tobin C. Harding) c7807dff9c2e772179c97f396be60ef37b2d7ba2 Run the formatter (Tobin C. Harding) Pull request description: We recently introduced `rustfmt` to the codebase but I forgot to turn it on in CI. - Patch 1: Preparatory formatting fixes, introduced since we merged the [formatting PR](rust-bitcoin/rust-secp256k1#499) - Patch 2: Enable formatting in CI - Patch 3: Add formatting to the pre-commit hook ACKs for top commit: apoelstra: ACK 75f3886812a70aa7821d3de38bf2e8c94cfd9ef4 Tree-SHA512: 5ac4ab4015a9728ef890e0c4fe90afcb5e45ab7665da5a8ee289dc877c1ea5c6236e54b68b7122841597864b04606c8bfae7dec86c4b6be74d32437299057b5f
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
75f3886812a70aa7821d3de38bf2e8c94cfd9ef4 Add cargo fmt to pre-commit githook (Tobin C. Harding) 0516ddeb8d62e88b3943406969a7665a5f123999 Add formatting check to CI (Tobin C. Harding) c7807dff9c2e772179c97f396be60ef37b2d7ba2 Run the formatter (Tobin C. Harding) Pull request description: We recently introduced `rustfmt` to the codebase but I forgot to turn it on in CI. - Patch 1: Preparatory formatting fixes, introduced since we merged the [formatting PR](rust-bitcoin/rust-secp256k1#499) - Patch 2: Enable formatting in CI - Patch 3: Add formatting to the pre-commit hook ACKs for top commit: apoelstra: ACK 75f3886812a70aa7821d3de38bf2e8c94cfd9ef4 Tree-SHA512: 5ac4ab4015a9728ef890e0c4fe90afcb5e45ab7665da5a8ee289dc877c1ea5c6236e54b68b7122841597864b04606c8bfae7dec86c4b6be74d32437299057b5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently introduced
rustfmtto the codebase but I forgot to turn it on in CI.