Add array constants #504
Merged
Add array constants #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
elichai
reviewed
Nov 3, 2022
src/constants.rs
Outdated
Comment on lines
87
to
89
| pub const ZERO: [u8; 32] = [ | ||
| 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, | ||
| ]; |
Member
Author
There was a problem hiding this comment.
lol, so it is :) Will use as suggested.
Member
There was a problem hiding this comment.
Will let you fix this before merging
apoelstra
previously approved these changes
Nov 5, 2022
In multiple places we use array constants for zero and one. Add two constants and use them throughout the codebase. Note the endian-ness of `ONE` in the docs.
Member
Author
|
Force pushed change to declaration of |
tcharding
force-pushed
the
11-03-const-zero-one
branch
from
6fa2962 to
603f441
Compare
apoelstra
approved these changes
Nov 6, 2022
apoelstra
added a commit
that referenced
this pull request
Nov 17, 2022
e0e575d Run cargo fmt (Tobin C. Harding) 41449e4 Prepare codebase for formatting (Tobin C. Harding) 7e3c893 Introduce rustfmt config file (Tobin C. Harding) Pull request description: (Includes the patch from #504, I pulled it out of this to merge faster) Introduce `rustfmt` by doing: - Copy the `rustfmt` config file from `rust-bitcoin` - Prepare the codebase by adding `#[rustfmt::skip]` as needed and doing some manual format improvements. - Run the formatter: `cargo +nightly fmt` - Add formatting checks to CI and the pre-commit hook Thanks in advance for doing the painful review on patch 3. ACKs for top commit: apoelstra: ACK e0e575d Tree-SHA512: 1b6fdbaf81480c0446e660cc3f6ab7ac0697f272187f6fdfd6b95d894a418cde8cf1c423f1d18ebbe03ac5c43489630a35ad07912afaeb6107cfbe7338a9bed7
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
603f441548fb198c07bd9bcb5b0c979a536bc6cb Add array constants (Tobin C. Harding)
Pull request description:
In multiple places we use array constants for zero and one. Add two constants and use them throughout the codebase. Note the endian-ness of `ONE` in the docs.
ACKs for top commit:
apoelstra:
ACK 603f441548fb198c07bd9bcb5b0c979a536bc6cb
Tree-SHA512: 70c455ee42f8a04feec37c3963b030c0f2c07b83801caf818dbb1661b7a0f65c4b92ff6a5df496a4dd6a917d13af4d60624a072c6f8a083293db9cd80d194232
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
603f441548fb198c07bd9bcb5b0c979a536bc6cb Add array constants (Tobin C. Harding)
Pull request description:
In multiple places we use array constants for zero and one. Add two constants and use them throughout the codebase. Note the endian-ness of `ONE` in the docs.
ACKs for top commit:
apoelstra:
ACK 603f441548fb198c07bd9bcb5b0c979a536bc6cb
Tree-SHA512: 70c455ee42f8a04feec37c3963b030c0f2c07b83801caf818dbb1661b7a0f65c4b92ff6a5df496a4dd6a917d13af4d60624a072c6f8a083293db9cd80d194232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiple places we use array constants for zero and one. Add two constants and use them throughout the codebase. Note the endian-ness of
ONEin the docs.