Deprecating tf2 C Headers

[CursedRock17]

Related to this pull request in geometry2 in which we deprecated the .h style headers in favor of .hpp.

[saikishor]

@CursedRock17 is this from rolling on? or does it affect Jazzy as well?

[CursedRock17]

This is from rolling onward, there aren't any plans of back porting yet.

[saikishor]

This is from rolling onward, there aren't any plans of back porting yet.

Thank you!

We will have to wait for the original PR to be merged and then we can get back to this.
In the meantime, Can you add conditioning in the code so that from rolling on it uses the .hpp, and in the prior versions it uses the .h version?

[destogl]

Thanks!

[saikishor]

@CursedRock17 I changed this PR to draft for now. Once your original PR is merged, please mark it as ready

[CursedRock17]

With the recent backports merged, this PR should be good for review.

[christophfroehlich]

The backport to jazzy hasn't been released yet, and on rolling it seems that they are not yet available on testing repo although the PR on rosdistro was merged. Let's wait until then, then we could merge because the binary-main jobs are failing already because we did the same with realtime_tools headers.

[github-actions]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (5eb04da) to head (53edf71).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1325   +/-   ##
=======================================
  Coverage   84.79%   84.79%           
=======================================
  Files         127      127           
  Lines       12114    12114           
  Branches     1036     1036           
=======================================
  Hits        10272    10272           
  Misses       1503     1503           
  Partials      339      339           

Flag	Coverage Δ
unittests	84.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp	75.07% <ø> (ø)
..._drive_controller/src/mecanum_drive_controller.cpp	90.72% <ø> (ø)
mecanum_drive_controller/src/odometry.cpp	100.00% <ø> (ø)
tricycle_controller/src/tricycle_controller.cpp	66.80% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[christophfroehlich]

@CursedRock17 as the upstream changes got synced we can go on with this.

Do you mind also fixing the occurrences of tf2/transform_datatypes.h this repo?