Skip to content

Conversation

traversaro
Copy link

@traversaro traversaro commented Jul 24, 2025

The fmt public dependency was added in the C++ code in #410, but without properly declaring the dependency in CMake and package.xml . The issue in the ros2-master branch was fixed by #391, but that PR was not backported to the jazzy branch.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@mergify
Copy link

mergify bot commented Jul 24, 2025

@traversaro, all pull requests must be targeted towards the ros2-master development branch.
Once merged into ros2-master, it is possible to backport to jazzy, but it must be in ros2-master
to have these changes reflected into new distributions.

@traversaro
Copy link
Author

@traversaro, all pull requests must be targeted towards the ros2-master development branch. Once merged into ros2-master, it is possible to backport to jazzy, but it must be in ros2-master to have these changes reflected into new distributions.

Hello bot, the ros2-master branch already contains that fix, that however was contained in a PR that was not backported.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.23%. Comparing base (dd5a768) to head (2b94696).

Additional details and impacted files
@@           Coverage Diff           @@
##            jazzy     #435   +/-   ##
=======================================
  Coverage   76.23%   76.23%           
=======================================
  Files          29       29           
  Lines        2066     2066           
  Branches      125      125           
=======================================
  Hits         1575     1575           
  Misses        420      420           
  Partials       71       71           
Flag Coverage Δ
unittests 76.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@christophfroehlich christophfroehlich merged commit 156d06e into ros-controls:jazzy Jul 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants