Skip to content

Conversation

saikishor
Copy link
Member

Second PR for the antiwindup strategy integration

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 75.55556% with 88 lines in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (0336ef4) to head (4d3fec5).

Files with missing lines Patch % Lines
control_toolbox/src/pid_ros.cpp 66.03% 32 Missing and 4 partials ⚠️
control_toolbox/src/pid.cpp 59.72% 24 Missing and 5 partials ⚠️
control_toolbox/include/control_toolbox/pid.hpp 68.49% 19 Missing and 4 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           ros2-master     #400      +/-   ##
===============================================
+ Coverage        76.72%   78.41%   +1.69%     
===============================================
  Files               30       30              
  Lines             1744     1886     +142     
  Branches           107      113       +6     
===============================================
+ Hits              1338     1479     +141     
+ Misses             346      338       -8     
- Partials            60       69       +9     
Flag Coverage Δ
unittests 78.41% <75.55%> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ontrol_toolbox/include/control_toolbox/pid_ros.hpp 100.00% <ø> (ø)
control_toolbox/test/pid_ros_parameters_tests.cpp 100.00% <100.00%> (ø)
control_toolbox/test/pid_ros_publisher_tests.cpp 96.15% <100.00%> (+1.15%) ⬆️
control_toolbox/test/pid_tests.cpp 100.00% <100.00%> (ø)
control_toolbox/include/control_toolbox/pid.hpp 67.28% <68.49%> (-10.98%) ⬇️
control_toolbox/src/pid.cpp 75.00% <59.72%> (+6.61%) ⬆️
control_toolbox/src/pid_ros.cpp 70.84% <66.03%> (+5.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor marked this pull request as ready for review June 12, 2025 21:11
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work!

Co-authored-by: Felix Exner (fexner) <[email protected]>
Copy link

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@urfeex
Copy link

urfeex commented Jun 17, 2025

Some tests are failing, though.

@saikishor
Copy link
Member Author

Some tests are failing, though.

I'll check

@christophfroehlich christophfroehlich added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Jun 17, 2025
@christophfroehlich christophfroehlich merged commit 910093d into ros2-master Jun 17, 2025
17 of 22 checks passed
@christophfroehlich christophfroehlich deleted the redefine/antiwindup/strategy branch June 17, 2025 10:55
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
(cherry picked from commit 910093d)

# Conflicts:
#	control_toolbox/include/control_toolbox/pid.hpp
#	control_toolbox/include/control_toolbox/pid_ros.hpp
#	control_toolbox/src/pid.cpp
christophfroehlich added a commit that referenced this pull request Jun 17, 2025
…ckport #400) (#410)

Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Christoph Froehlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants