Skip to content

[JSON Logic] Part 7: Add conditional logic checking #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Sep 18, 2023
Merged

[JSON Logic] Part 7: Add conditional logic checking #41

merged 52 commits into from
Sep 18, 2023

Conversation

@brennj
Copy link
Collaborator

@brennj brennj commented Aug 24, 2023

Definitely a more involved one 😅 :

  • We will parse conditionals now in x-jsf-logic via a special processJSONLogicNode function which goes through anything particular to JSON logic.
  • During the calculation of conditional properties, we'll now calculated computed attributes if any and spread them, we'll also apply any validations that need to be added.
  • Adds the logic for the special if statements only available in x-jsf-logic (which can have an if statement without properties but computedValues and validations checks)
  • Lots of tests and schemas with more to come (breaking some extra tests into its own PR because theres just so much...)

This was referenced Aug 24, 2023
Closed
Closed
sandrina-p
sandrina-p reviewed Aug 31, 2023
View reviewed changes
@sandrina-p sandrina-p mentioned this pull request Aug 31, 2023
Merged
brennj added 26 commits August 31, 2023 16:40
@brennj
feat: JSON Logic skeleton and plumbing setup
87d2d9b 
chore: clean up conditional additions

chore: remove const tests

chore: remove dupe file

chore: remove group array stuff

chore: clean up yupschema

chore: clean up helpers a small bit

chore: remove all error handling for now

chore: clean up package-lock

chore: more removing stuff

chore: clean more
@brennj
chore: support barebones computedAttrs
d2cc213
@brennj
chore: fix errors
cf8f9bd
@brennj
chore: fix mess ups from rebase
2eca83f
@brennj
chore: feedback from PR
b305047
@brennj
chore: pass logic down at updateFieldsProperties to prevent bugs
edbc56f
@brennj
Release 0.5.0-dev.20230901130231
55ed296
@brennj
Revert "Release 0.5.0-dev.20230901130231"
54f7c42 
This reverts commit 55ed296.
@brennj
feat: JSON Logic skeleton and plumbing setup
2710f51 
chore: clean up conditional additions

chore: remove const tests

chore: remove dupe file

chore: remove group array stuff

chore: clean up yupschema

chore: clean up helpers a small bit

chore: remove all error handling for now

chore: clean up package-lock

chore: more removing stuff

chore: clean more
@brennj
chore: support barebones computedAttrs
da20a93
@brennj
chore: computed string attributes
195825d
@brennj
chore: fix tests
9118b09
@brennj
chore: consistency for curly braces
5f32f21
@brennj
chore: remove unneeded code for now
a40da7b
@brennj
feat: JSON Logic skeleton and plumbing setup
35d0fd1 
chore: clean up conditional additions

chore: remove const tests

chore: remove dupe file

chore: remove group array stuff

chore: clean up yupschema

chore: clean up helpers a small bit

chore: remove all error handling for now

chore: clean up package-lock

chore: more removing stuff

chore: clean more

chore: support barebones computedAttrs

chore: computed string attributes

chore: error handling
@brennj
chore: fix tests
57b90af
@brennj
chore: review errors
a186d13
@brennj
chore: fix up code for fixtures
aa3432b
@brennj
chore: add a bunch of docs to try and make things clearer
40679e5
@brennj
chore: add example to docs
8d54d43
@brennj
chore: higher level console check
df9b1a6
@brennj
chore: use cases to clean up error tests
81402ed
@brennj
chore: add more tests for missing vars
827ba1b
@brennj
chore: use switch statement instead
02a0ff5
@brennj
chore: add code comments why schemas fail
8cc22e0
@brennj
feat: JSON Logic skeleton and plumbing setup
36e6845 
chore: clean up conditional additions

chore: remove const tests

chore: remove dupe file

chore: remove group array stuff

chore: clean up yupschema

chore: clean up helpers a small bit

chore: remove all error handling for now

chore: clean up package-lock

chore: more removing stuff

chore: clean more

chore: support barebones computedAttrs

chore: error handling

feat: add more error handling
@brennj brennj force-pushed the conditionals-json-logic branch from d037d27 to 2beb330 Compare September 6, 2023 12:56
@brennj
Copy link
Collaborator Author

brennj commented Sep 7, 2023

I think everything is covered here, let me know if I'm missing anything

@sandrina-p sandrina-p mentioned this pull request Sep 12, 2023
Merged
@brennj brennj force-pushed the conditionals-json-logic branch from a354811 to 1f15939 Compare September 13, 2023 14:24
brennj
brennj commented Sep 13, 2023
View reviewed changes
johnstonbl01
johnstonbl01 previously approved these changes Sep 13, 2023
View reviewed changes
Base automatically changed from inline-rule-handling to main September 15, 2023 12:21
@brennj brennj dismissed johnstonbl01’s stale review September 15, 2023 12:21

The base branch was changed.

@brennj brennj merged commit 6292b01 into main Sep 18, 2023
@brennj brennj deleted the conditionals-json-logic branch September 18, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandrina-p sandrina-p sandrina-p approved these changes

@johnstonbl01 johnstonbl01 johnstonbl01 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brennj @johnstonbl01 @sandrina-p