[JSON Logic] Part 6: Inline rule handling for computedAttrs #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrina-p
reviewed
Aug 31, 2023
sandrina-p
reviewed
Aug 31, 2023
chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more
This reverts commit 55ed296.
chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more
chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more chore: support barebones computedAttrs chore: computed string attributes chore: error handling
chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more chore: support barebones computedAttrs chore: error handling feat: add more error handling
brennj
force-pushed
the
general-error-handling
branch
from
3eb38a2 to
70a1430
Compare
brennj
force-pushed
the
inline-rule-handling
branch
from
f050bb8 to
23c5773
Compare
brennj
force-pushed
the
inline-rule-handling
branch
from
23c5773 to
2d6eac7
Compare
|
this part is good to go for another round of reviews |
|
This one looks good to me. Will defer to Sandrina on her previous comments. |
sandrina-p
reviewed
Sep 12, 2023
Base automatically changed from
general-error-handling
to
add-string-based-computedAttrs
September 13, 2023 08:35
johnstonbl01
previously approved these changes
Sep 13, 2023
sandrina-p
previously approved these changes
Sep 14, 2023
brennj
dismissed stale reviews from sandrina-p and johnstonbl01
via
bb335dd
dilvane
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the code needed to actually compute inline rules in
x-jsf-logic-computedAttrswhen they're defined in that keyword as opposed to inx-jsf-logic. Adds a bunch of tests and matching schemas to illustrate its capabilities.