[JSON Logic] Part 8: Conditional logic additional tests cases #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more
This reverts commit 93fb420.
brennj
force-pushed
the
conditionals-json-logic
branch
from
d037d27 to
2beb330
Compare
|
Closing this one as on further review don't think it makes sense to seperate, and one less piece of the puzzle to worry about 😂 |
sandrina-p
reviewed
Sep 12, 2023
| ] | ||
| }, | ||
| "dependencies": { | ||
| "json-logic-js": "^2.0.2", |
There was a problem hiding this comment.
I'm lost. Wasn't this PR all about new test cases? Where are they now that you closed the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct follow up from #41
Lots of tests that expand upon what this functionality can do! Refer to previous MR for what.