- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.3k
Add Numeric Suite Tutorial to prototype #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add TorchScript fork/join tutorial
Add note about zipfile format in serialization tutorial
* Profiler recipe Summary: Adding a recipe for profiler Test Plan: make html-noplot
[mobile] Mobile Perf Recipe
…omop [android][recipe] Making android native app using torchscript model with custom op
…s_last [mobile_perf][recipe] Add ChannelsLast recommendation
Adding distributed pipeline parallel tutorial
Add async execution tutorials
Fix code block in pipeline tutorial
* Adding an Overview Page for PyTorch Distributed * Let existing PT Distributed tutorials link to the overview page * Add a link to AMP * Address Comments * Remove unnecessary dist.barrier()
* [Mobile Perf Recipe] Add the benchmarking part for iOS * [Mobile Perf Recipe] Add the benchmarking part for iOS Co-authored-by: Jessica Lin <[email protected]>
| Deploy preview for pytorch-tutorials-preview ready! Built with commit c9fadcb https://deploy-preview-1064--pytorch-tutorials-preview.netlify.app | 
| @hx89 - For your FYI, here is a direct preview link to your tutorial: https://deploy-preview-1064--pytorch-tutorials-preview.netlify.app/prototype/numeric_suite_tutorial.html Looks like there are some syntax issues with the headers. I can try to help reformat and share with you the updates | 
Made some syntax edits because original headings were not rendering properly and breaking the build:
- Removed the lines of pound sign (#) delimiters under text because when placed under text, it renders them all as headers
- Add lines of pound delimiters above certain blocks of text to force them to show up as plain text between the code rather than comments with the code
- Added code syntax  (e.g.``compare_weights``)
Suggestions: 
- Link to code or documentation (for example in the beginning when referencing new code or new concepts)
- Add a conclusion section with links to references or learn more at the end
    - Examples:
https://pytorch.org/tutorials/intermediate/dynamic_quantization_bert_tutorial.html#conclusion
Fixes:
- Currently the tutorial references images in `/_static/img/` but they are placed in `/_static/`. Make sure these match up.
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full details for review in this pr to the hx89:master for: hx89#1
* Initial commit * Update * Complete most of recipe * Add image * Link image * Remove extra file * update * Update * update
jlin27_numeric_suite_tutorial
* Update feature classification labels * Update NVidia -> Nvidia * Bring back default filename_pattern so that by default we run all galleries. Signed-off-by: Edward Z. Yang <[email protected]> * Add prototype_source directory * Add prototype directory * Add prototype * Remove extra "done" * Add REAME.txt * Update for prototype instructions * Update for prototype feature * refine torchvision_tutorial doc for windows * Update neural_style_tutorial.py (pytorch#1059) Updated the mistake in the Loading Images Section. * torch_script_custom_ops restructure (pytorch#1057) Signed-off-by: Edward Z. Yang <[email protected]> * Port custom ops tutorial to new registration API, increase testability. Signed-off-by: Edward Z. Yang <[email protected]> * Kill some other occurrences of RegisterOperators Signed-off-by: Edward Z. Yang <[email protected]> * Update README.md * Make torch_script_custom_classes tutorial runnable I also fixed some warnings in the tutorial, and fixed some minor bitrot (e.g., torch::script::Module to torch::jit::Module) I also added some missing quotes around some bash expansions. Signed-off-by: Edward Z. Yang <[email protected]> * Update torch_script_custom_classes to use TORCH_LIBRARY (pytorch#1062) Signed-off-by: Edward Z. Yang <[email protected]> Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: Yang Gu <[email protected]> Co-authored-by: Hritik Bhandari <[email protected]>
* Update feature classification labels * Update NVidia -> Nvidia * Bring back default filename_pattern so that by default we run all galleries. Signed-off-by: Edward Z. Yang <[email protected]> * Tutorial for DDP + RPC. Summary: Based on example from pytorch/examples#800 * Add to main section Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Added separate code file and used literalinclude Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: Jessica Lin <[email protected]> Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: pritam <[email protected]>
* Update feature classification labels * Update NVidia -> Nvidia * Bring back default filename_pattern so that by default we run all galleries. Signed-off-by: Edward Z. Yang <[email protected]> * Add prototype_source directory * Add prototype directory * Add prototype * Remove extra "done" * Add REAME.txt * Update for prototype instructions * Update for prototype feature * refine torchvision_tutorial doc for windows * Update neural_style_tutorial.py (pytorch#1059) Updated the mistake in the Loading Images Section. * torch_script_custom_ops restructure (pytorch#1057) Signed-off-by: Edward Z. Yang <[email protected]> * Port custom ops tutorial to new registration API, increase testability. Signed-off-by: Edward Z. Yang <[email protected]> * Kill some other occurrences of RegisterOperators Signed-off-by: Edward Z. Yang <[email protected]> * Update README.md * Make torch_script_custom_classes tutorial runnable I also fixed some warnings in the tutorial, and fixed some minor bitrot (e.g., torch::script::Module to torch::jit::Module) I also added some missing quotes around some bash expansions. Signed-off-by: Edward Z. Yang <[email protected]> * Update torch_script_custom_classes to use TORCH_LIBRARY (pytorch#1062) Signed-off-by: Edward Z. Yang <[email protected]> * Add Graph Mode Dynamic Quant tutorial Summary: Tutorial to demonstrate graph mode dynamic quant on BERT model. Currently not directly runnable as it requires to download glue dataset and fine-tuned model Co-authored-by: Jessica Lin <[email protected]> Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: Yang Gu <[email protected]> Co-authored-by: Hritik Bhandari <[email protected]>
* Update feature classification labels * Update NVidia -> Nvidia * Bring back default filename_pattern so that by default we run all galleries. Signed-off-by: Edward Z. Yang <[email protected]> * Add prototype_source directory * Add prototype directory * Add prototype * Remove extra "done" * Add REAME.txt * Update for prototype instructions * Update for prototype feature * refine torchvision_tutorial doc for windows * Update neural_style_tutorial.py (pytorch#1059) Updated the mistake in the Loading Images Section. * torch_script_custom_ops restructure (pytorch#1057) Signed-off-by: Edward Z. Yang <[email protected]> * Port custom ops tutorial to new registration API, increase testability. Signed-off-by: Edward Z. Yang <[email protected]> * Kill some other occurrences of RegisterOperators Signed-off-by: Edward Z. Yang <[email protected]> * Update README.md * Make torch_script_custom_classes tutorial runnable I also fixed some warnings in the tutorial, and fixed some minor bitrot (e.g., torch::script::Module to torch::jit::Module) I also added some missing quotes around some bash expansions. Signed-off-by: Edward Z. Yang <[email protected]> * Update torch_script_custom_classes to use TORCH_LIBRARY (pytorch#1062) Signed-off-by: Edward Z. Yang <[email protected]> * Add Model Freezing in TorchScript Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: Yang Gu <[email protected]> Co-authored-by: Hritik Bhandari <[email protected]>
* Add TorchScript fork/join tutorial * Add note about zipfile format in serialization tutorial * Profiler recipe (pytorch#1019) * Profiler recipe Summary: Adding a recipe for profiler Test Plan: make html-noplot * [mobile] Mobile Perf Recipe * Minor syntax edits to mobile perf recipe * Remove built files * [android] android native app recipe * [mobile_perf][recipe] Add ChannelsLast recommendation * Adding distributed pipeline parallel tutorial * Add async execution tutorials * Fix code block in pipeline tutorial * Adding an Overview Page for PyTorch Distributed (pytorch#1056) * Adding an Overview Page for PyTorch Distributed * Let existing PT Distributed tutorials link to the overview page * Add a link to AMP * Address Comments * Remove unnecessary dist.barrier() * [Mobile Perf Recipe] Add the benchmarking part for iOS (pytorch#1055) * [Mobile Perf Recipe] Add the benchmarking part for iOS * [Mobile Perf Recipe] Add the benchmarking part for iOS Co-authored-by: Jessica Lin <[email protected]> * Add files via upload * Create numeric_suite_tutorial.py * jlin27_numeric_suite_tutorial Made some syntax edits because original headings were not rendering properly and breaking the build: - Removed the lines of pound sign (#) delimiters under text because when placed under text, it renders them all as headers - Add lines of pound delimiters above certain blocks of text to force them to show up as plain text between the code rather than comments with the code - Added code syntax (e.g.``compare_weights``) Suggestions: - Link to code or documentation (for example in the beginning when referencing new code or new concepts) - Add a conclusion section with links to references or learn more at the end - Examples: https://pytorch.org/tutorials/intermediate/dynamic_quantization_bert_tutorial.html#conclusion Fixes: - Currently the tutorial references images in `/_static/img/` but they are placed in `/_static/`. Make sure these match up. * Delete compare_output.png * Delete compare_stub.png * Delete shadow.png * Add files via upload * RPC profiling recipe (pytorch#1068) * Initial commit * Update * Complete most of recipe * Add image * Link image * Remove extra file * update * Update * update * Update numeric_suite_tutorial.py * Update numeric_suite_tutorial.py * Push latest changes from master into release/1.6 (pytorch#1074) * Update feature classification labels * Update NVidia -> Nvidia * Bring back default filename_pattern so that by default we run all galleries. Signed-off-by: Edward Z. Yang <[email protected]> * Add prototype_source directory * Add prototype directory * Add prototype * Remove extra "done" * Add REAME.txt * Update for prototype instructions * Update for prototype feature * refine torchvision_tutorial doc for windows * Update neural_style_tutorial.py (pytorch#1059) Updated the mistake in the Loading Images Section. * torch_script_custom_ops restructure (pytorch#1057) Signed-off-by: Edward Z. Yang <[email protected]> * Port custom ops tutorial to new registration API, increase testability. Signed-off-by: Edward Z. Yang <[email protected]> * Kill some other occurrences of RegisterOperators Signed-off-by: Edward Z. Yang <[email protected]> * Update README.md * Make torch_script_custom_classes tutorial runnable I also fixed some warnings in the tutorial, and fixed some minor bitrot (e.g., torch::script::Module to torch::jit::Module) I also added some missing quotes around some bash expansions. Signed-off-by: Edward Z. Yang <[email protected]> * Update torch_script_custom_classes to use TORCH_LIBRARY (pytorch#1062) Signed-off-by: Edward Z. Yang <[email protected]> Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: Yang Gu <[email protected]> Co-authored-by: Hritik Bhandari <[email protected]> * Tutorial for DDP + RPC (pytorch#1071) * Update feature classification labels * Update NVidia -> Nvidia * Bring back default filename_pattern so that by default we run all galleries. Signed-off-by: Edward Z. Yang <[email protected]> * Tutorial for DDP + RPC. Summary: Based on example from pytorch/examples#800 * Add to main section Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Added separate code file and used literalinclude Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: Jessica Lin <[email protected]> Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: pritam <[email protected]> * Make RPC profiling recipe into prototype tutorial (pytorch#1078) * Add RPC tutorial * Update to include recipes * Add Graph Mode Dynamic Quant tutorial (pytorch#1065) * Update feature classification labels * Update NVidia -> Nvidia * Bring back default filename_pattern so that by default we run all galleries. Signed-off-by: Edward Z. Yang <[email protected]> * Add prototype_source directory * Add prototype directory * Add prototype * Remove extra "done" * Add REAME.txt * Update for prototype instructions * Update for prototype feature * refine torchvision_tutorial doc for windows * Update neural_style_tutorial.py (pytorch#1059) Updated the mistake in the Loading Images Section. * torch_script_custom_ops restructure (pytorch#1057) Signed-off-by: Edward Z. Yang <[email protected]> * Port custom ops tutorial to new registration API, increase testability. Signed-off-by: Edward Z. Yang <[email protected]> * Kill some other occurrences of RegisterOperators Signed-off-by: Edward Z. Yang <[email protected]> * Update README.md * Make torch_script_custom_classes tutorial runnable I also fixed some warnings in the tutorial, and fixed some minor bitrot (e.g., torch::script::Module to torch::jit::Module) I also added some missing quotes around some bash expansions. Signed-off-by: Edward Z. Yang <[email protected]> * Update torch_script_custom_classes to use TORCH_LIBRARY (pytorch#1062) Signed-off-by: Edward Z. Yang <[email protected]> * Add Graph Mode Dynamic Quant tutorial Summary: Tutorial to demonstrate graph mode dynamic quant on BERT model. Currently not directly runnable as it requires to download glue dataset and fine-tuned model Co-authored-by: Jessica Lin <[email protected]> Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: Yang Gu <[email protected]> Co-authored-by: Hritik Bhandari <[email protected]> * Add mobile recipes images * Update mobile recipe index * Remove RPC Profiling recipe from index * 1.6 model freezing tutorial (pytorch#1077) * Update feature classification labels * Update NVidia -> Nvidia * Bring back default filename_pattern so that by default we run all galleries. Signed-off-by: Edward Z. Yang <[email protected]> * Add prototype_source directory * Add prototype directory * Add prototype * Remove extra "done" * Add REAME.txt * Update for prototype instructions * Update for prototype feature * refine torchvision_tutorial doc for windows * Update neural_style_tutorial.py (pytorch#1059) Updated the mistake in the Loading Images Section. * torch_script_custom_ops restructure (pytorch#1057) Signed-off-by: Edward Z. Yang <[email protected]> * Port custom ops tutorial to new registration API, increase testability. Signed-off-by: Edward Z. Yang <[email protected]> * Kill some other occurrences of RegisterOperators Signed-off-by: Edward Z. Yang <[email protected]> * Update README.md * Make torch_script_custom_classes tutorial runnable I also fixed some warnings in the tutorial, and fixed some minor bitrot (e.g., torch::script::Module to torch::jit::Module) I also added some missing quotes around some bash expansions. Signed-off-by: Edward Z. Yang <[email protected]> * Update torch_script_custom_classes to use TORCH_LIBRARY (pytorch#1062) Signed-off-by: Edward Z. Yang <[email protected]> * Add Model Freezing in TorchScript Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: Yang Gu <[email protected]> Co-authored-by: Hritik Bhandari <[email protected]> Co-authored-by: James Reed <[email protected]> Co-authored-by: Jessica Lin <[email protected]> Co-authored-by: ilia-cher <[email protected]> Co-authored-by: Ivan Kobzarev <[email protected]> Co-authored-by: Shen Li <[email protected]> Co-authored-by: Shen Li <[email protected]> Co-authored-by: Tao Xu <[email protected]> Co-authored-by: Rohan Varma <[email protected]> Co-authored-by: Edward Z. Yang <[email protected]> Co-authored-by: Yang Gu <[email protected]> Co-authored-by: Hritik Bhandari <[email protected]> Co-authored-by: Pritam Damania <[email protected]> Co-authored-by: pritam <[email protected]> Co-authored-by: supriyar <[email protected]> Co-authored-by: Jessica Lin <[email protected]>
Add Numeric Suite Tutorial to prototype