jlin27_numeric_suite_tutorial #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some syntax edits because original headings were not rendering properly and breaking the build:
- Removed the lines of pound sign (#) delimiters under text because when placed under text, it renders them all as headers
- Add lines of pound delimiters above certain blocks of text to force them to show up as plain text between the code rather than comments with the code
- Added code syntax (e.g.``compare_weights``)
Suggestions:
- Link to code or documentation (for example in the beginning when referencing new code or new concepts)
- Add a conclusion section with links to references or learn more at the end
- Examples:
https://pytorch.org/tutorials/intermediate/dynamic_quantization_bert_tutorial.html#conclusion
Fixes:
- Currently the tutorial references images in `/_static/img/` but they are placed in `/_static/`. Make sure these match up.
Author
|
Here is a screenshot of it built locally: screencapture-file-Users-jplin-github-hx89-tutorials-build-html-prototype-numeric-suite-tutorial-html-2020-07-14-18_30_11.pdf |
Owner
|
Thanks @jlin27 for your feedback and revisions, it looks much better now! Just wonder how should I proceed to incorporate your revisions and suggestions, should I merge your PR to my master and continue editing on top of it? And I want the tutorial to print out the outputs of each cell for demonstration purpose, what should I do to enable that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some syntax edits because original headings were not rendering properly and breaking the build:
compare_weights)Suggestions:
https://pytorch.org/tutorials/intermediate/dynamic_quantization_bert_tutorial.html#conclusion
Fixes:
/_static/img/but they are placed in/_static/. Make sure these match up.