Skip to content

Conversation

@mrshenli
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 30, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 3501c76

https://deploy-preview-1045--pytorch-tutorials-preview.netlify.app

@mrshenli mrshenli changed the title [WIP] Add async execution tutorials Add async execution tutorials Jul 1, 2020
@mrshenli
Copy link
Contributor Author

mrshenli commented Jul 1, 2020

cc @jlin27

@mrshenli mrshenli force-pushed the batch branch 4 times, most recently from 9db4d8f to 42dcdf2 Compare July 1, 2020 21:42
Copy link
Contributor

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few commments.

side, when getting the ``Future`` object, it installs subsequent RPC response
preparation and communication as callbacks as well, which will be triggered
when the final result is ready. In this way, the callee no longer needs to block
one thread and wait until the final return value is ready Please refer to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "." after ready


The rest of the code is normal processes launching and logging which are
similar to other RPC tutorials. In this tutorial, all observers passively
waiting for commands from the agent. please refer to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize "Please"



.. figure:: /_static/img/rpc-images/batch.png
:alt: No newline at end of file
Copy link
Contributor

@jlin27 jlin27 Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add a "Learn More" section at the end that links out resources users can follow to continue their learnings on this topic (e.g. RPC Examples: ttps://github.com/pytorch/examples/tree/master/distributed/rpc/batch, the next tutorial, etc).

@mrshenli mrshenli changed the base branch from master to release/1.6 July 2, 2020 21:20
@mrshenli
Copy link
Contributor Author

mrshenli commented Jul 2, 2020

Generated locally and looks fine:

batch

@jlin27 jlin27 merged commit aef2568 into pytorch:release/1.6 Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants