Remove python3.7 from build matrix #1416
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
|
We need to remove it from nightly only, please keep it in release. Change similar to CUDA_ACRHES_DICT but for python is required |
Why? Upcoming release should not have 3.7 and we do not plan 1.13.2, do we? And even if we do, it will not be affected by the change? And going forward, I guess we should either introduce versioned releases to the matrix, or make release builds checkout release branch of this repo |
|
cc @malfet It will automatically remove 3.7 from release validation, if there is regression meanwhile in 1.13.1 (untill we release 2.0) where 3.7 builds will fail for any reason, we will not catch it. Since we claim to support 3.7 for previous release, I would probably tend to stay on safe side. This is the only reason. Its kind of edge case, true. |
|
@atalman an interesting point. Are you saying that our EOL Python matrix should be driven by release cycles? |
|
@malfet true we should probably not fix any new issues for 3.7 since we are deprecating it. But its for us to know if we are claiming 3.7 Python support for 1.13, I would expect the installation instructions to still work, specially this is current stable version. If its broken for some reason while we have not released next stable version, it would still be worthwhile to be aware of the breakage and either mitigate it or advise clients. |
|
Should we merge this one or #1475 ? |
|
I will merge #1475 , in future if needed, we can remerge this. |
|
Close this one as #1475 was merged instead of this one. |
Similar to pytorch/test-infra#1416 but for binary build Pull Request resolved: #92919 Approved by: https://github.com/atalman
Related: pytorch/pytorch#80513