Skip to content

Remove python3.7 from build matrix #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove python3.7 from build matrix #1416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01e8772
Remove python3.7 from build matrix
weiwangmeta Jan 19, 2023
a7d7241
testing revert this
weiwangmeta Jan 24, 2023
b064ba1
Undo changes to working dir
weiwangmeta Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tools/scripts/generate_binary_build_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

mod = sys.modules[__name__]

FULL_PYTHON_VERSIONS = ["3.7", "3.8", "3.9", "3.10"]
FULL_PYTHON_VERSIONS = ["3.8", "3.9", "3.10"]

CUDA_ACRHES_DICT = {
"nightly": ["11.6", "11.7", "11.8"],
Expand Down Expand Up @@ -211,9 +211,6 @@ def generate_conda_matrix(os: str, channel: str, with_cuda: str) -> List[Dict[st
# We don't build CUDA 10.2 for window see https://github.com/pytorch/pytorch/issues/65648
arches += list_without(mod.CUDA_ARCHES, ["10.2"])

if os == "macos-arm64":
python_versions = list_without(python_versions, ["3.7"])

for python_version in python_versions:
# We don't currently build conda packages for rocm
for arch_version in arches:
Expand Down Expand Up @@ -343,8 +340,6 @@ def generate_wheels_matrix(
if python_versions is None:
# Define default python version
python_versions = list(FULL_PYTHON_VERSIONS)
if os == "macos-arm64":
python_versions = list_without(python_versions, ["3.7"])

if os == "linux":
# NOTE: We only build manywheel packages for linux
Expand Down