Skip to content

drop support for Python 3.7 #7110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2023
Merged

drop support for Python 3.7 #7110

merged 3 commits into from
Jan 27, 2023

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Jan 19, 2023 •
edited by pytorch-bot bot
Loading

According to pytorch/pytorch#80513 (comment), core will drop support for 3.7 with the upcoming torch==2.0.0 release. We should do the same.

cc @seemethere

@pmeier pmeier requested a review from NicolasHug January 19, 2023 07:06
pmeier
pmeier commented Jan 19, 2023
View reviewed changes
setup.py
pytorch_dep += "==" + os.getenv("PYTORCH_VERSION")

requirements = [
"typing_extensions",
Copy link
Contributor Author

@pmeier pmeier Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only ever used this for Literal, which is available through typing in the standard library for Python >= 3.8.

@pmeier
Copy link
Contributor Author

pmeier commented Jan 19, 2023

We have some failing 3.7 jobs that we have no influence over. They are generated here from

vision/.github/workflows/build-wheels-linux.yml

Line 12 in 93df9a5

uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
. Thus, this PR is blocked by pytorch/test-infra#1416.

This was referenced Jan 26, 2023
Merged
Closed
@pmeier pmeier linked an issue Jan 27, 2023 that may be closed by this pull request
Discard py3.7 tests from CI #7137
Closed
@pmeier
Copy link
Contributor Author

pmeier commented Jan 27, 2023

pytorch/test-infra#1416 was closed in favor of pytorch/test-infra#1475. IIUC, this was done since PyTorch core tests stable binaries as well: pytorch/test-infra#1416 (comment). I'm fairly certain we don't so we should be good to remove everywhere. cc @atalman and @malfet to be sure.

@pmeier
Copy link
Contributor Author

pmeier commented Jan 27, 2023

CI failures seem unrelated. I'll deal with them today.

@pmeier pmeier marked this pull request as ready for review January 27, 2023 09:58
@YosuaMichael YosuaMichael mentioned this pull request Jan 27, 2023
Open
malfet
malfet approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I wonder if we it'll be at all possible possible use more templating to make this change smaller in the future

NicolasHug
NicolasHug approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip!

@pmeier pmeier merged commit 78ffda7 into pytorch:main Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Jan 27, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the drop-py37 branch January 27, 2023 15:45
@weiwangmeta weiwangmeta mentioned this pull request Jan 30, 2023
Closed
@pmeier pmeier mentioned this pull request Feb 6, 2023
Closed
facebook-github-bot pushed a commit that referenced this pull request Feb 8, 2023
@NicolasHug @facebook-github-bot
[fbsync] drop support for Python 3.7 (#7110)
1c2e30c 
Summary: Co-authored-by: Nikita Shulga <[email protected]>

Reviewed By: vmoens

Differential Revision: D43116112

fbshipit-source-id: a106557ca98afd84e179a53e1665b44c7fd9bcb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

cla signed module: ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Discard py3.7 tests from CI

4 participants

@pmeier @NicolasHug @malfet @facebook-github-bot