Skip to content

[Build] Set proper C++ ABI #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2021
Merged

[Build] Set proper C++ ABI #880

merged 1 commit into from
Jan 12, 2021

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Aug 14, 2020 •
edited
Loading

With this change, BUILD_TRANSDUCER=1 python setup.py build_ext now sees -D_GLIBCXX_USE_CXX11_ABI= in the compilation command. (Note: sox is C-only so it is not relevant to sox build process)

[ 98%] Building CXX object transducer/CMakeFiles/warprnnt.dir/submodule/src/rnnt_entrypoint.cpp.o
cd /scratch/moto/torchaudio/build/temp.linux-x86_64-3.8/third_party/transducer && /home/moto/ccache/lib/c++  -DRNNT_DISABLE_OMP -I/scratch/moto/torchaudio/third_party/transducer/submodule/include  -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC   -o CMakeFiles/warprnnt.dir/submodule/src/rnnt_entrypoint.cpp.o -c /scratch/moto/torchaudio/third_party/transducer/submodule/src/rnnt_entrypoint.cpp

See also: pytorch/text#931

@mthrok mthrok changed the title Disable C++11 ABI when necessary for libtorch compatibility [Build] Disable C++11 ABI when necessary for libtorch compatibility Aug 14, 2020
@mthrok mthrok force-pushed the abi branch 5 times, most recently from 41690ab to 1718d40 Compare August 19, 2020 19:44
@mthrok mthrok force-pushed the abi branch 2 times, most recently from e1f64d0 to b70fb96 Compare August 31, 2020 17:39
@mthrok mthrok marked this pull request as ready for review January 9, 2021 02:20
@mthrok mthrok mentioned this pull request Jan 9, 2021
Merged
@mthrok mthrok changed the title [Build] Disable C++11 ABI when necessary for libtorch compatibility [Build] Set proper C++ ABI Jan 9, 2021
@mthrok mthrok mentioned this pull request Jan 9, 2021
Merged
vincentqb
vincentqb approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit 72b7680 into pytorch:master Jan 12, 2021
@mthrok mthrok deleted the abi branch January 12, 2021 19:06
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
@brianjo
Merge pull request pytorch#880 from jamesr66a/cpp_class_op
2ea3972 
Add section about C++ classes as op args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

+1 more reviewer

@vincentqb vincentqb vincentqb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mthrok @cpuhrsch @vincentqb @facebook-github-bot