This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Use Ninja to build extensions and disable C++11 ABI when necessary for libtorch compatibility. #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 13, 2020 14:01
cpuhrsch
changed the title
cpuhrsch
changed the title
added 4 commits
August 13, 2020 14:56
cpuhrsch
changed the title
seemethere
approved these changes
Aug 13, 2020
malfet
approved these changes
Aug 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
=======================================
Coverage 77.23% 77.23%
=======================================
Files 44 44
Lines 3009 3009
=======================================
Hits 2324 2324
Misses 685 685 Continue to review full report at Codecov.
|
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 14, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 14, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 14, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 14, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 15, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 19, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 28, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 31, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jan 9, 2021
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jan 12, 2021
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jan 12, 2021
mthrok
added a commit
to pytorch/audio
that referenced
this pull request
Jan 12, 2021
…880) With this change, `BUILD_TRANSDUCER=1 python setup.py build_ext` now sees `-D_GLIBCXX_USE_CXX11_ABI=` in the compilation command. (Note: sox is C-only so it is not relevant to sox build process) See also: - pytorch/text#931 - https://stackoverflow.com/a/55406930
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.