Skip to content

[Build] Set proper C++ ABI #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2021
Merged

[Build] Set proper C++ ABI #880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions build_tools/setup_helpers/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import subprocess
from pathlib import Path

import torch
from torch.utils.cpp_extension import (
CppExtension,
BuildExtension as TorchBuildExtension
Expand Down Expand Up @@ -109,12 +110,22 @@ def _get_libraries():
return [] if _BUILD_SOX else ['sox']


def _get_cxx11_abi():
try:
value = int(torch._C._GLIBCXX_USE_CXX11_ABI)
except ImportError:
value = 0
return f'-D_GLIBCXX_USE_CXX11_ABI={value}'


def _build_third_party(base_build_dir):
build_dir = os.path.join(base_build_dir, 'third_party')
os.makedirs(build_dir, exist_ok=True)
subprocess.run(
args=[
'cmake',
f"-DCMAKE_CXX_FLAGS='{_get_cxx11_abi()}'",
'-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON',
f'-DCMAKE_INSTALL_PREFIX={_TP_INSTALL_DIR}',
f'-DBUILD_SOX={"ON" if _BUILD_SOX else "OFF"}',
f'-DBUILD_TRANSDUCER={"ON" if _BUILD_TRANSDUCER else "OFF"}',
Expand Down