-
Notifications
You must be signed in to change notification settings - Fork 739
Add HTK format support to sox_io's save & info #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Edit comment to trigger CI
mthrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. The PR looks good. Can you resolve the conflict due to #1275 ?
Done. Thank you! |
Update comment to trigger CI
Merge latest code from main repo
|
Thanks! |
|
I forgot to mention adding one validation. Could you do a follow-up? audio/torchaudio/csrc/sox/io.cpp Lines 265 to 271 in 3488f31
audio/torchaudio/csrc/sox/io.cpp Lines 131 to 135 in 3488f31
|
With advice & help from @mthrok, added
htkformat to sox_io's save function & info test.htk is a single channel 16-bit PCM format used by HTK, a toolkit for building Hidden Markov Model speech processing tools.