Added GSM format support to soxio's save function #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably already know this, but the failed tests seem to be flaky for some reason. The failures are highly likely to go away if you'd trigger CI again. |
Yeah, this one is giving me headaches and blocking the release of file-like object support feature for sox-io backend. I will have to make a PR to disable these against release branch soon. It's such a high demand feature so I wanted to release it but the reality is hard |
mthrok
approved these changes
Feb 18, 2021
|
Thanks! |
prabhat00155
added a commit
to prabhat00155/audio
that referenced
this pull request
Feb 23, 2021
(cherry picked from commit 490a53e)
prabhat00155
added a commit
to prabhat00155/audio
that referenced
this pull request
Feb 23, 2021
(cherry picked from commit 490a53e)
mthrok
pushed a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1264.