Add GSM encoding support to info #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I can also add an info-test for |
mthrok
reviewed
Feb 18, 2021
Contributor
mthrok
left a comment
mthrok
left a comment
There was a problem hiding this comment.
The implementation looks good. Can you add tests? Thanks.
Contributor
Author
Added |
Contributor
Author
|
@mthrok, please confirm if you were referring to the htk info test, or some other tests. Thanks! |
Merge latest code from main repo
mthrok
approved these changes
Feb 19, 2021
Contributor
|
Thanks for working on this. It looks good. |
Test GSM for up to 16 channels
Remove check from num_frames from GSM
mthrok
changed the title
Contributor
|
Thanks! |
Contributor
|
If you have time, can you cherry-pick this PR and make a PR against |
mthrok
pushed a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @mthrok's help, the following tasks were completed in this PR:
get_encodingfromtorchaudio/csrc/sox/io.cpptotorchaudio/csrc/sox/types.cpp.