Fixing NOLINT mishap #3260
Merged
Fixing NOLINT mishap #3260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I mindlessly tried to remove all NOLINT one-by-one, running clang-tidy locally for each. Two can be removed, the three remaining are definitely needed. Question @Skylion007: could there be valid use cases that need the extra NOLINT I removed (beyond the one you pointed out)? If yes, would it make sense to add a test case? |
Collaborator
|
Not really, if the Eigen tests pass then everything should be fine as the only meaningful const should be the one that goes into the caster and only as an edge case like how we used it for Eigen. |
Collaborator
Author
|
Awesome, thanks Aaron! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing NOLINT accidentally added with PR #3254.