Fixing NOLINT mishap (#3260)

rwgk · web-flow · commit 121b91f99c90 · 2021-09-10T10:16:09.000-04:00
* Removing NOLINT pointed out by Aaron.

* Removing another NOLINT.
diff --git a/include/pybind11/cast.h b/include/pybind11/cast.h
@@ -1200,7 +1200,6 @@ class argument_loader {
     }
 
     template <typename Return, typename Guard, typename Func>
-    // NOLINTNEXTLINE(readability-const-return-type)
     enable_if_t<std::is_void<Return>::value, void_type> call(Func &&f) && {
         std::move(*this).template call_impl<remove_cv_t<Return>>(std::forward<Func>(f), indices{}, Guard{});
         return void_type();
@@ -1224,7 +1223,6 @@ class argument_loader {
     }
 
     template <typename Return, typename Func, size_t... Is, typename Guard>
-    // NOLINTNEXTLINE(readability-const-return-type)
     Return call_impl(Func &&f, index_sequence<Is...>, Guard &&) && {
         return std::forward<Func>(f)(cast_op<Args>(std::move(std::get<Is>(argcasters)))...);
     }

Original file line number	Diff line number	Diff line change
`@@ -1200,7 +1200,6 @@ class argument_loader {`
`1200`	`1200`	`}`
`1201`	`1201`
`1202`	`1202`	`template <typename Return, typename Guard, typename Func>`
`1203`		`- // NOLINTNEXTLINE(readability-const-return-type)`
`1204`	`1203`	`enable_if_t<std::is_void<Return>::value, void_type> call(Func &&f) && {`
`1205`	`1204`	`std::move(*this).template call_impl<remove_cv_t<Return>>(std::forward<Func>(f), indices{}, Guard{});`
`1206`	`1205`	`return void_type();`
`@@ -1224,7 +1223,6 @@ class argument_loader {`
`1224`	`1223`	`}`
`1225`	`1224`
`1226`	`1225`	`template <typename Return, typename Func, size_t... Is, typename Guard>`
`1227`		`- // NOLINTNEXTLINE(readability-const-return-type)`
`1228`	`1226`	`Return call_impl(Func &&f, index_sequence<Is...>, Guard &&) && {`
`1229`	`1227`	`return std::forward<Func>(f)(cast_op<Args>(std::move(std::get<Is>(argcasters)))...);`
`1230`	`1228`	`}`