Skip to content

Fixing NOLINT mishap #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Fixing NOLINT mishap #3260

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a85a0
Removing NOLINT pointed out by Aaron.
rwgk Sep 10, 2021
e8d3c31
Removing another NOLINT.
rwgk Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/pybind11/cast.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,7 +1200,6 @@ class argument_loader {
}

template <typename Return, typename Guard, typename Func>
// NOLINTNEXTLINE(readability-const-return-type)
enable_if_t<std::is_void<Return>::value, void_type> call(Func &&f) && {
std::move(*this).template call_impl<remove_cv_t<Return>>(std::forward<Func>(f), indices{}, Guard{});
return void_type();
Expand All @@ -1224,7 +1223,6 @@ class argument_loader {
}

template <typename Return, typename Func, size_t... Is, typename Guard>
// NOLINTNEXTLINE(readability-const-return-type)
Return call_impl(Func &&f, index_sequence<Is...>, Guard &&) && {
return std::forward<Func>(f)(cast_op<Args>(std::move(std::get<Is>(argcasters)))...);
}
Expand Down