Skip to content

Revert "Bring back #5255 "SelectPanel: Prepare for non-anchored variants"" #5272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

Revert "Bring back #5255 "SelectPanel: Prepare for non-anchored variants"" #5272

merged 1 commit into from
Nov 13, 2024

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 13, 2024

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 089306c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp self-assigned this Nov 13, 2024
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Nov 13, 2024
@github-actions github-actions bot added the staff Author is a staff member label Nov 13, 2024
@siddharthkp siddharthkp marked this pull request as ready for review November 13, 2024 15:25
@siddharthkp siddharthkp requested a review from a team as a code owner November 13, 2024 15:25
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.79 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 98.99 KB (-0.19% 🔽)

@siddharthkp siddharthkp added the integration-tests: skipped manually Changes in this PR do not require an integration test label Nov 13, 2024
@siddharthkp siddharthkp added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 0389f42 Nov 13, 2024
53 checks passed
@siddharthkp siddharthkp deleted the revert-5262-revert-5255-revert-5230-selectpanel-use-anchored-position branch November 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@siddharthkp siddharthkp

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp @joshblack