Bring back #5255 "SelectPanel: Prepare for non-anchored variants" #5262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 080e0f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
|
🟢 golden-jobs completed with status |
github-actions
bot
added
integration-tests: failing
This reverts commit f0be480.
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350750 |
github-actions
bot
added
integration-tests: passing
siddharthkp
changed the title
siddharthkp
changed the title
broccolinisoup
approved these changes
Nov 12, 2024
broccolinisoup
deleted the
revert-5255-revert-5230-selectpanel-use-anchored-position
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diff from PR that had to be reverted:
The reason I had to revert it is because i added one commit after running integration tests that was faulty 🤦