Skip to content

Revert "SelectPanel: Prepare for non-anchored variants" #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

Revert "SelectPanel: Prepare for non-anchored variants" #5255

merged 1 commit into from
Nov 8, 2024

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 8, 2024 •
edited
Loading

@siddharthkp siddharthkp self-assigned this Nov 8, 2024
@changeset-bot

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the staff Author is a staff member label Nov 8, 2024
@siddharthkp siddharthkp added skip changeset This change does not need a changelog and removed staff Author is a staff member labels Nov 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 8, 2024
@siddharthkp siddharthkp marked this pull request as ready for review November 8, 2024 21:02
@siddharthkp siddharthkp requested a review from a team as a code owner November 8, 2024 21:02
@siddharthkp siddharthkp requested a review from keithamus November 8, 2024 21:02
@siddharthkp siddharthkp enabled auto-merge November 8, 2024 21:03
@siddharthkp siddharthkp added integration-tests: skipped manually Changes in this PR do not require an integration test integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test labels Nov 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.64 KB (-0.22% 🔽)
packages/react/dist/browser.umd.js 99.05 KB (-0.18% 🔽)

@siddharthkp siddharthkp added this pull request to the merge queue Nov 8, 2024
@primer-integration
Copy link

primer-integration bot commented Nov 8, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350652

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@primer-integration
Copy link

primer-integration bot commented Nov 8, 2024

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 8, 2024
@github-actions github-actions bot added the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Nov 8, 2024
@siddharthkp siddharthkp added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 64802f1 Nov 8, 2024
60 checks passed
@siddharthkp siddharthkp deleted the revert-5230-selectpanel-use-anchored-position branch November 8, 2024 21:39
This was referenced Nov 8, 2024
Closed
Merged
siddharthkp added a commit that referenced this pull request Nov 11, 2024
@siddharthkp
Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)…
dc3d2c0 
…" (#5255)"

This reverts commit 64802f1.
@siddharthkp siddharthkp mentioned this pull request Nov 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2024
@siddharthkp
Bring back #5255 "SelectPanel: Prepare for non-anchored variants" (#5262
fca4ec9 
)

* Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)" (#5255)"

This reverts commit 64802f1.

* Revert "tiny formatting to make it easier to review"

This reverts commit f0be480.

* different way of writing the same thing
siddharthkp added a commit that referenced this pull request Nov 13, 2024
@siddharthkp
Revert "Bring back #5255 "SelectPanel: Prepare for non-anchored varia…
089306c 
…nts" (#5…"

This reverts commit fca4ec9.
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@siddharthkp
Revert "Bring back #5255 "SelectPanel: Prepare for non-anchored varia…
0389f42 
…nts" (#5…" (#5272)

This reverts commit fca4ec9.
siddharthkp added a commit that referenced this pull request Nov 13, 2024
@siddharthkp
Revert "Bring back #5255 "SelectPanel: Prepare for non-anchored varia…
37e10d0 
…nts" (#5…"

This reverts commit fca4ec9.
siddharthkp added a commit that referenced this pull request Nov 13, 2024
@siddharthkp
Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)…
2d6fa8f 
…" (#5255)"

This reverts commit 64802f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@francinelucca francinelucca francinelucca approved these changes

Assignees

@siddharthkp siddharthkp

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siddharthkp @joshblack @francinelucca