Skip to content

Conversation

@joshblack
Copy link
Member

Addresses a current release blocker where leading, trailing props were not being spread onto the base button causing an "unknown DOM attribute" warning from React.

Changelog

New

Changed

  • Add leadingIcon, leadingVisual, trailingIcon, and trailingVisual to destructure list for ButtonBase props

Removed

@joshblack joshblack requested review from a team and mperrotti September 14, 2023 17:23
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: 387e0a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Sep 14, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 100.7 KB (+0.01% 🔺)
dist/browser.umd.js 101.28 KB (-0.01% 🔽)

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@siddharthkp siddharthkp added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit a2eb0f6 Sep 15, 2023
@siddharthkp siddharthkp deleted the fix/update-passthrough-button-props branch September 15, 2023 05:10
@siddharthkp siddharthkp mentioned this pull request Sep 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants