Skip to content

Commit 387e0a7

Browse files
committed
fix(ButtonBase): remove leading, trailing props from being spread onto base button
1 parent a3f14f7 commit 387e0a7

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/Button/ButtonBase.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ import {defaultSxProp} from '../utils/defaultSxProp'
1111
const ButtonBase = forwardRef(
1212
({children, as: Component = 'button', sx: sxProp = defaultSxProp, ...props}, forwardedRef): JSX.Element => {
1313
const {
14+
leadingIcon,
15+
leadingVisual,
16+
trailingIcon,
17+
trailingVisual,
1418
trailingAction: TrailingAction,
1519
icon: Icon,
1620
variant = 'default',
@@ -19,8 +23,8 @@ const ButtonBase = forwardRef(
1923
block = false,
2024
...rest
2125
} = props
22-
const LeadingVisual = props.leadingVisual ?? props.leadingIcon
23-
const TrailingVisual = props.trailingVisual ?? props.trailingIcon
26+
const LeadingVisual = leadingVisual ?? leadingIcon
27+
const TrailingVisual = trailingVisual ?? trailingIcon
2428

2529
const innerRef = React.useRef<HTMLButtonElement>(null)
2630
useRefObjectAsForwardedRef(forwardedRef, innerRef)

0 commit comments

Comments
 (0)