Release Tracking #3736
Description
This is a scheduled issue for tracking the release between Monday 11th and Friday 15th
| Last week | Value |
|---|---|
| Issue | Release Tracking |
| Conductor | siddharthkp |
| Release Pull Request | Link |
| Integration tests | Link |
Timeline
Tuesday, Sept 12
- Integration PR has broken tests, looks like there are some breaking changes in the release
Wednesday, , Sept 13
- Fixes for backward breaking changes:
- Export ActionMenu/index for backward compatibility with #3713 #3740
- fix(PageLayout): restore main landmark #3737
Thursday, Sept 14
-
Integration PR isn't green yet, there seems to be a React prop that is passed through to the underlying element
Warning: React does not recognize the `leadingIcon` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `leadingicon` instead. If you accidentally passed it from a parent component, remove it from the DOM element. at a at onClick (/workspace/github/node_modules/react-router-dom/index.tsx:473:7)It is likely coming from one of these 2 files:
- react-code-view/components/blob-edit/templates/LicenseSelector.tsx#L22
- react-code-view/components/blob-edit/templates/CodeOfConductSelector.tsx#L21
Both have a
Button as={Link} leadingIcon={icon}/>where the Link points to @github-ui/react-core/linkThis is related to this tiny change: https://github.com/primer/react/pull/3715/files#diff-d63160e1a0bc6e1b413bf57891f51fc3a16158f9bbe8dba87aacf395f2644ef2L14-L15 from feat(Button): add support for leadingVisual and trailingVisual #3715
Because the fix is straightforward, I'd like for us to fix it instead of revert it. (hopefully before something else gets merged and breaks main of course 💀 )
Friday, Sept 15
- Merged fix for leadingIcon: fix(ButtonBase): remove leading, trailing props from being spread onto base butotn #3744
- Integration tests still failing
Monday - Tuesday, Sept 18 - 19
- Release conductor is on holiday 😇
Wednesday, Sept 20
- There is only 1 flaky flaky test in dotcom that is not related to this specific release, so we should be fine!
- Released v35.30.0
Checklist
- Checks have passed on the integration Pull Request downstream (almost, see update ↑)
- Release tracking Pull Request has been merged
- Stable release available on npm
- Downstream repos have been updated to latest