Skip to content

Change page_sidebar() and page_navbar() to default to fillable=False #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2024
Merged

Change page_sidebar() and page_navbar() to default to fillable=False #990

merged 3 commits into from
Jan 10, 2024

Conversation

@wch
Copy link
Collaborator

@wch wch commented Jan 10, 2024

Closes #938. This PR changes page_sidebar() and page_navbar() to default to fillable=False.

@wch wch requested a review from cpsievert January 10, 2024 21:20
@wch wch merged commit b0582f1 into main Jan 10, 2024
@wch wch deleted the no-fillable-default branch January 10, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

For page_sidebar and page_navbar, consider changing default for fillable to False

3 participants

@wch @cpsievert