Skip to content

Change page_sidebar() and page_navbar() to default to fillable=False #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Change page_sidebar() and page_navbar() to default to fillable=False #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80af87d
Change page_sidebar() and page_navbar() to default to fillable=False
wch Jan 10, 2024
ca6d6a6
Update changelog
wch Jan 10, 2024
a357d97
Merge branch 'main' into no-fillable-default
wch Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED]

### Breaking Changes

* Closed #938: `page_sidebar()` and `page_navbar()` now use `fillable=False` by default. (#990)

### New features

Expand Down
4 changes: 2 additions & 2 deletions shiny/ui/_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def page_sidebar(
sidebar: Sidebar,
*args: TagChild | TagAttrs,
title: Optional[str | Tag | TagList] = None,
fillable: bool = True,
fillable: bool = False,
fillable_mobile: bool = False,
window_title: str | MISSING_TYPE = MISSING,
lang: Optional[str] = None,
Expand Down Expand Up @@ -116,7 +116,7 @@ def page_navbar(
sidebar: Optional[Sidebar] = None,
# Only page_navbar gets enhanced treatement for `fillable`
# If an `*args`'s `data-value` attr string is in `fillable`, then the component is fillable
fillable: bool | list[str] = True,
fillable: bool | list[str] = False,
fillable_mobile: bool = False,
gap: Optional[CssUnit] = None,
padding: Optional[CssUnit | list[CssUnit]] = None,
Expand Down