Skip to content

Commit b0582f1

Browse files
authored
Change page_sidebar() and page_navbar() to default to fillable=False (#990)
1 parent 05de458 commit b0582f1

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88

99
## [UNRELEASED]
1010

11+
### Breaking Changes
12+
13+
* Closed #938: `page_sidebar()` and `page_navbar()` now use `fillable=False` by default. (#990)
1114

1215
### New features
1316

shiny/ui/_page.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def page_sidebar(
4444
sidebar: Sidebar,
4545
*args: TagChild | TagAttrs,
4646
title: Optional[str | Tag | TagList] = None,
47-
fillable: bool = True,
47+
fillable: bool = False,
4848
fillable_mobile: bool = False,
4949
window_title: str | MISSING_TYPE = MISSING,
5050
lang: Optional[str] = None,
@@ -116,7 +116,7 @@ def page_navbar(
116116
sidebar: Optional[Sidebar] = None,
117117
# Only page_navbar gets enhanced treatement for `fillable`
118118
# If an `*args`'s `data-value` attr string is in `fillable`, then the component is fillable
119-
fillable: bool | list[str] = True,
119+
fillable: bool | list[str] = False,
120120
fillable_mobile: bool = False,
121121
gap: Optional[CssUnit] = None,
122122
padding: Optional[CssUnit | list[CssUnit]] = None,

0 commit comments

Comments
 (0)