test: Resolve testing comments #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you make the change also to use 1920 x 1080 resolution for the viewport before each test? @pytest.fixture(scope="function")
# By going to `about:blank`, we _reset_ the page to a known state before each test.
# It is not perfect, but it is faster than making a new page for each test.
# This must be done before each test
def page(session_page: Page) -> Page:
session_page.goto("about:blank")
session_page.set_viewport_size({"width": 1920, "height": 1080})
return session_pagein |
schloerke
added a commit
that referenced
this pull request
Mar 15, 2024
* main: Add support for Shiny Express in Quarto Dashboards, take 2 (#1217) Force UTF-8 for Shiny Express on Windows (#1203) Typing fixes feat(card): Report full screen state as a Shiny input (#1215) Use TypeScript strict mode (#1208) Update author email test: Resolve testing comments (#1206) Fix URL Update badges Bump dev version to 0.8.1.9000 (#1202) chore(deps): Update bslib css (#1200) chore: no new features v0.8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1197
cc @karangattu