Skip to content

test: Resolve testing comments #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2024
Merged

test: Resolve testing comments #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
833e08b
Resolve comment; Upload artifact on failure
schloerke Mar 8, 2024
66bcd8f
Resolve comment; Remove duplicate if statement
schloerke Mar 8, 2024
dce9fa7
Use 1080p window size
schloerke Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/pytest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ jobs:
run: |
make playwright-deploys SUB_FILE=". -vv"

- uses: actions/upload-artifact@v4
if: failure()
with:
name: "playright-examples-${{ matrix.os }}-${{ matrix.python-version }}-results"
path: test-results/
retention-days: 5

playwright-deploys:
needs: [playwright-deploys-precheck]
if: github.event_name != 'release' && (github.event_name == 'push' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'deploy')))
Expand Down Expand Up @@ -171,7 +178,6 @@ jobs:
make playwright-deploys SUB_FILE=". -vv"

- name: Deploy apps and run tests (on `push` or on `pull_request` w/ `deploy**` branch)
if: ${{ github.event_name == 'push' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'deploy')) }}
env:
DEPLOY_APPS: "true"
DEPLOY_CONNECT_SERVER_URL: "https://rsc.radixu.com/"
Expand Down
2 changes: 2 additions & 0 deletions tests/playwright/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ def session_page(browser: BrowserContext) -> Page:
# This must be done before each test
def page(session_page: Page) -> Page:
session_page.goto("about:blank")
# Reset screen size to 1080p
session_page.set_viewport_size({"width": 1920, "height": 1080})
return session_page


Expand Down