Skip to content

Commit aba83ed

Browse files
authored
test: Resolve testing comments (#1206)
1 parent cd1b994 commit aba83ed

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.github/workflows/pytest.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,13 @@ jobs:
142142
run: |
143143
make playwright-deploys SUB_FILE=". -vv"
144144
145+
- uses: actions/upload-artifact@v4
146+
if: failure()
147+
with:
148+
name: "playright-examples-${{ matrix.os }}-${{ matrix.python-version }}-results"
149+
path: test-results/
150+
retention-days: 5
151+
145152
playwright-deploys:
146153
needs: [playwright-deploys-precheck]
147154
if: github.event_name != 'release' && (github.event_name == 'push' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'deploy')))
@@ -171,7 +178,6 @@ jobs:
171178
make playwright-deploys SUB_FILE=". -vv"
172179
173180
- name: Deploy apps and run tests (on `push` or on `pull_request` w/ `deploy**` branch)
174-
if: ${{ github.event_name == 'push' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'deploy')) }}
175181
env:
176182
DEPLOY_APPS: "true"
177183
DEPLOY_CONNECT_SERVER_URL: "https://rsc.radixu.com/"

tests/playwright/conftest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ def session_page(browser: BrowserContext) -> Page:
5555
# This must be done before each test
5656
def page(session_page: Page) -> Page:
5757
session_page.goto("about:blank")
58+
# Reset screen size to 1080p
59+
session_page.set_viewport_size({"width": 1920, "height": 1080})
5860
return session_page
5961

6062

0 commit comments

Comments
 (0)