Remove instances of insecure randomness #1956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for substrate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Daanvdplas
reviewed
Apr 13, 2023
sacha-l
commented
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1908.
Did a pass on articles, guides and tutorials to remove all mentions of the insecure randomness pallet as we want to discourage it's use. The only place it's still used is in the Collectibles tutorial which may need to be revised, but imo for creating DNA as a learning piece, it's OK to use the insecure randomness pallet.