Skip to content

IE Shim #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

IE Shim #180

wants to merge 2 commits into from

Conversation

MrRio
Copy link
Member

@MrRio MrRio commented Feb 7, 2014

Not ready to pull. Still in stubbed.

@MrRio MrRio assigned diegocr and MrRio and unassigned diegocr Feb 7, 2014
@MrRio
Copy link
Member Author

MrRio commented Feb 7, 2014

@diegocr We have a few examples of this working in the wild that need porting across to the plugin

@MrRio
Copy link
Member Author

MrRio commented Feb 7, 2014

Not sure how many people are using older versions of IE but we may need to think of an easy API for them to add the downloadify download button.

@diegocr
Copy link
Contributor

diegocr commented Feb 7, 2014

Hi, I merely deleted the jspdf.plugin.ie_below_9_shim.js file due its redundancy, since currently it serves no purpose other than replacing the output() function with the internal one, which is already being done in jspdf.js, and unnecessarily "bloating" the generated jspdf.min.js - i could modify uglify.sh so that it isn't compiled, though.

@diegocr
Copy link
Contributor

diegocr commented Feb 7, 2014

For reference, there are just a few IE-related issues opened: #47, #64, #139

as you, i dunno how many users of older IE versions are around, and if it worth the trouble supporting such versions, we may can just hereby request to anybody interested on that to post here so that we can be aware we should spent some time improving the support for them. (?)

@Merg1255
Copy link

Merg1255 commented Feb 8, 2014

@MrRio and @diegocr : thanks for making updates on the project :)
I too believe that jspdf should target modern browsers, since previous version systems are working with other pdf software already. IMHO supporting utf8 would be a much better needed feature than increasing the library file size only for a small portion of browsers.

@throrin19
Copy link

@MrRio and @diegocr, I think, ie9+ support is suffisant, a lot of people use the ie9 version and the part of users is important. You don't ignore that. I agree with you, ie( support sucks a lot but it's necessary and important. Only developers use chrome or other modern browser.

@barrystoner
Copy link

Hello Mr Rio,

Thank you for your work on this plugin and sharing it with us.

I have been trying to work out from the thread if IE8 and 9 support has been pulled. Is it correct that under IE10 i no longer supported? If so, can you make this clearer on the homepage of your website? I read the following text 'Current build does not have IE6-9 shim enabled' to mean that I could simply enable it of for my work.

Hopefully I've misunderstood and can simply enable the shim, and if that is the case can you let me know how to to it please?

Kind regards,

Barry

@umasreey
Copy link

i am facing problem in IE 8 with jspdf type expected error while saving the pdf file . Its in the blob function. Any suggestions for this. I am blocked by this. I tested in IE9 i am facing the same problem. Please help me. for this fix.

@ReneCreaBea
Copy link

I also want to activate the ie6-9 shim, because the website where I use your plugin in, has a large number of IE-users. Can you please explain how I can enable the feature.

With best regards,
René

@StamKtuvet
Copy link

I'm also interested in a fix for IE9.

@ghost
Copy link

ghost commented Sep 11, 2014

I would love a fix/shim/hack for IE9. I tried using the Downloadify plugin but it didn't respond well with the recent addHTML() feature.

@danielalmeidagoncalves
Copy link

Would be very interesting a fix/shim/hack for IE9 without the use of Downloadify, many enterprise products have restrict policies in the use of flash in their applications.

@peterbehr
Copy link

Having trouble figuring out where the presumably deactivated shim for IE is and how it works. IE9 support, with or without Downloadify, would be very desirable to have. Can anyone point to any relevant documentation or commits in the project? Thanks!

@christrude
Copy link

Has anyone watching this thread figured out how to utilize/enable downloadify yet? I sent a message today to @MrRio on twitter seeking direction.

@RyanDansie
Copy link

I agree with the comments from @bstoner123. Your website suggests that ie6-9 support can be enabled but here it looks like it has been decided to abandon support for ie6-9. It would be nice if this could be clarified either way, and updated on the website if necessary.

@jkjustjoshing
Copy link

I just spent 4 hours pulling my hair out trying to figure out why this isn't working in IE9. Please clarify @MrRio!

@jeremyckahn
Copy link

I would also like to request a definitive answer to the question of IE support. Does this project still support IE<10? Is there documentation that could be linked to or updated to prevent further confusion?

@wonderb0lt
Copy link

Bump. I wouldn't mind doing some work myself, but I have no idea how to get started on this.

@goozo
Copy link

goozo commented Jan 11, 2017

Just to let some people know how I got jsPDF to work with ie8 but with Downloadify:

I had to use version 1.0.106 of jsPDF and follow the downloadify example in the examples dir, which has the base64 polyfill lib plus swfobject plus the downloadify.min.js plus I needed to add an extra polyfill for Object.keys before loading the jsPDF itself.

@thgreasi
Copy link

How about creating a PR or a sample project under your GitHub account?

@Uzlopak
Copy link
Collaborator

Uzlopak commented Feb 19, 2018

This PR got a common discussion thread instead of being a real PR.

Dismissed for the goal to support StandardJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.