[Forwardport] Improvements to the CONTRIBUTING.md document #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cart. - Added mftf test.
…oduct from /checkout/cart page after already been removed from mini-shopping cart - updated annotation
…mode - GitHub issue magento#14104
Enable WebAPI interface to handle parameters through constructor magento#14801 - New optional param should be last in the params list.
…structor magento#14801 - Merge Pull Request magento#14801 from phoenix128/magento2:webapi-support-immutable-construct-params - Merged commits: 1. fd6aa64 2. 04a53a8 3. 6e68edf 4. 68e5dcd 5. a63a3b5 6. 089e77a 7. ac921c7 8. 4426cdb
…ase\Model\AddressIn as its type.
Accepted Public Pull Requests: - magento#15128: [Forwardport] chore: use random_int() in some places (by @mzeis)
…Test::testIsInheritedLocalizedException
…move deprecated private method getSerializer, injected in constructor instead
…icationStorage class magento#15263 - Merge Pull Request magento#15263 from adrian-martinez-interactiv4/magento2:2.3-develop-PR-port-15262 - Merged commits: 1. ed368b0
…options are not selected. - Added mftf test.
…ucts. - Updated story annotation.
- Added supporting file - Added JS unit tests
- creating a class to hide from printing needed elements
…oding styles doesn't work for PageBuilder code - add modules to whitelist to enable static test `\Magento\Test\Less\LiveCodeTest`
…magento#11517 - provided initial value for shiftedValue
- Merge Pull Request magento#15466 from mzeis/magento2:2.3-develop-PR-port-15431 - Merged commits: 1. d56a57b
…omparison block - removing if that doesn't check the first item
…assigned-attribute-n-a
…0-unassigned-attribute-n-a
…agento-honey-badgers/magento2ce into MAGETWO-91440-unassigned-attribute-n-a
…440-unassigned-attribute-n-a [honey] Bug Fixes
…-Extension-Attributes [architects] MAGETWO-90358: Auto-generate ExtensionAttributes object
Accepted Public Pull Requests: - magento#15466: [Forwardport] typo correction (by @mzeis) - magento#15450: ADHOC: update the contribution templates to include a note on results (by @dmanners)
- Merge Pull Request magento#15492 from lfluvisotto/magento2:2.3-develop-return-tag-misspelled - Merged commits: 1. 8e14879
- Merge Pull Request magento#15489 from lfluvisotto/magento2:2.3-develop-duplicate-array-keys - Merged commits: 1. 9ebdcc5
Accepted Public Pull Requests: - magento#15360: 15210-Fixed product tier pricing pagination issue in admin (by @saravananvelu) - magento#15489: Duplicate array keys (by @lfluvisotto) - magento#15492: Return tag misspelled (by @lfluvisotto) Fixed GitHub Issues: - magento#15210: Advanced pricing pagination issue (reported by @dryadav) has been fixed in magento#15360 by @saravananvelu in 2.3-develop branch Related commits: 1. cad44a3 2. 560aa38 3. 8a8ed66 4. ba6bf77 5. 6de6006 6. ec3eb1a 7. 75960ce
…es & link updates.
osrecio
pushed a commit
that referenced
this pull request
Jun 22, 2018
…nto#15726 - Merge Pull Request magento#15726 from sanjay-wagento/magento2:2.3-develop-PR-port-13026 - Merged commits: 1. ce176d2
osrecio
pushed a commit
that referenced
this pull request
Jun 22, 2018
osrecio
pushed a commit
that referenced
this pull request
Jun 22, 2018
Accepted Public Pull Requests: - magento#16275: Simplified TypeProcessor (by @joni-jones) - magento#15842: [Forwardport] Add missing table aliases to fields mapping for Customer Group filter� (by @hitesh-wagento) - magento#15744: [Forwardport] [BUGFIX] magento#15564 Generated admin API token expires immediately (by @vijay-wagento) - magento#15726: Forwardport] Feature space between category page #1 (by @sanjay-wagento) - magento#15698: [Forwardport] Variant product image in sidebar wishlist block (by @dmytro-ch) - magento#15672: [FORWARDPORT magento#15097] Add field to filter to collection (by @dverkade) - magento#16256: magento#15255 unlock customer after password reset (by @vgelani) - magento#16246: [Forwardport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP (by @lfluvisotto) - magento#16224: [Forwardport] Correct return type of methods and typo correction. (by @saurabh-aureate) - magento#16225: Navigation dropdown caret icon. (by @tejash-wagento) - magento#15980: Use correct error message for duplicate error key in product import (by @denteblu) Fixed GitHub Issues: - magento#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined (reported by @radio) has been fixed in magento#15842 by @hitesh-wagento in 2.3-develop branch Related commits: 1. 0f23ed7 - magento#15564: 2.2.4 Created admin token has no access (reported by @krukas) has been fixed in magento#15744 by @vijay-wagento in 2.3-develop branch Related commits: 1. 7f34b22 2. 349d178 - magento#12601: A space between the category page and the main footer when applying specific settings (reported by @wd7080) has been fixed in magento#15726 by @sanjay-wagento in 2.3-develop branch Related commits: 1. ce176d2 - magento#15255: Customer who exceeded max login failures not able to login even after reset password (reported by @tizzyguy87) has been fixed in magento#16256 by @vgelani in 2.3-develop branch Related commits: 1. a108233
osrecio
pushed a commit
that referenced
this pull request
Jul 19, 2018
[Forwardport] Fixed typo mistake in function comment
osrecio
pushed a commit
that referenced
this pull request
Jul 19, 2018
[Forwardport] When searching for the title if search for all the segments that has …
nmalevanec
pushed a commit
that referenced
this pull request
Feb 15, 2019
Add Brazilian Credit Cards Support #1
nmalevanec
pushed a commit
that referenced
this pull request
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15460
Description
Wording changes & link updates to CONTRIBUTING.md.
Contribution checklist