Skip to content

Improvements to the CONTRIBUTING.md document #15460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2018
Merged

Improvements to the CONTRIBUTING.md document #15460

merged 1 commit into from
May 25, 2018

Conversation

@RebeccaBrocton
Copy link
Contributor

@RebeccaBrocton RebeccaBrocton commented May 23, 2018 •
edited by avoelkl
Loading

Description

Wording changes & link updates to CONTRIBUTING.md.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 23, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@avoelkl
Copy link
Contributor

avoelkl commented May 23, 2018

Hi @RebeccaBrocton!
Thanks or your pull request! Let's get this processed :)

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 23, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 23, 2018

Hi @avoelkl, thank you for the review.
ENGCOM-1658 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 23, 2018

@RebeccaBrocton thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit cf973f2 into magento:2.2-develop May 25, 2018
magento-engcom-team pushed a commit that referenced this pull request May 25, 2018
ENGCOM-1658: Improvements to the CONTRIBUTING.md document #15460
4f86476
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 25, 2018

Hi @RebeccaBrocton. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

This was referenced May 25, 2018
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@avoelkl avoelkl avoelkl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@avoelkl avoelkl

Labels

Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.5

Development

Successfully merging this pull request may close these issues.

4 participants

@RebeccaBrocton @magento-cicd2 @avoelkl @magento-engcom-team