[Backport][22.3] Only require libmanagement_ext if it's actually needed. #5332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems/apps, libawt_headless gets pulled in. This currently brings in libmanagement_ext unconditionally. However, libmanagement_ext should only be present for linking iff com.sun.management.internal.OperatingSystemImpl class becomes reachable. Closes: oracle#5119
oracle-contributor-agreement
bot
added
the
OCA Verified
zakkak
changed the title
gilles-duboscq
requested review from
ezzarghili
and removed request for
gilles-duboscq
Member
|
@ezzarghili could you please review this PR, please let me know when the PR is ready to be mirrored to bitbucket. Thank you |
Member
|
LGTM, @oubidar-Abderrahim please follow up on this PR. |
Collaborator
|
Any update on this? |
Member
|
The PRs are merged into our CPU branched internally, they will show up once they get mirrored to GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #5122 (backport applied cleanly)
Closes #5273